Consume boxel-ui directly#5471
Open
ef4 wants to merge 4 commits into
Open
Conversation
This removes the build step in boxel-ui. To keep the public import paths simple despite the constraint that package.json exports can't do extension search, I opted to make all the publicly importable modules use `.gts` extension. Since it's a superset of `.ts` there's no harm in using it even in a file that has no templates. The way the exports rules are written, an import ending in an explicit `.css` will map to `.css`, and anything else will get an implied `.gts`. The test-app needed to gain basic infrastructure for glimmer-scoped-css- and ember-concurrency, since those are no longer compiled away in boxel-ui's own build. This is consistent with the support that host already has anyway. This PR keeps the build scripts but makes them into no-ops, since they're touched by a lot of the CI infrastructure. A followup PR can eliminate them. Also, the rollup dependencies and config in boxel-ui could get eliminated after this PR lands.
3 tasks
Contributor
Preview deploymentsHost Test Results 1 files 1 suites 2h 57m 6s ⏱️ Results for commit f3d57a3. Realm Server Test Results 1 files ± 0 1 suites +1 10m 53s ⏱️ + 10m 53s Results for commit f3d57a3. ± Comparison against earlier commit 184ca7a. |
burieberry
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the build step in boxel-ui.
To keep the public import paths simple despite the constraint that package.json exports can't do extension search, I opted to make all the publicly importable modules use
.gtsextension. Since it's a superset of.tsthere's no harm in using it even in a file that has no templates. The way the exports rules are written, an import ending in an explicit.csswill map to.css, and anything else will get an implied.gts.The test-app needed to gain basic infrastructure for glimmer-scoped-css- and ember-concurrency, since those are no longer compiled away in boxel-ui's own build. This is consistent with the support that host already has anyway.
This PR keeps the build scripts but makes them into no-ops, since they're touched by a lot of the CI infrastructure. A followup PR can eliminate them.
Also, the rollup dependencies and config in boxel-ui could get eliminated after this PR lands.