Skip to content

Give the definition-container header a whole-pixel min-height #6078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
backspace wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Give the definition-container header a whole-pixel min-height #6078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/boxel-ui/src/components/header/usage.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ export default class HeaderUsage extends Component {
</FreestyleUsage>
<style scoped>
.definition-container {
--boxel-header-min-height: 1.56rem;
/* 25px exactly. 1.56rem is 24.96px, and a fractional height
leaves every engine to round it its own way — which is how
the same content lands a pixel apart between browsers. */
--boxel-header-min-height: 1.5625rem;
--boxel-header-padding: var(--boxel-sp-5xs) var(--boxel-sp-xs);
--boxel-header-background-color: var(--boxel-300);
--boxel-header-text-color: var(--boxel-dark);
Expand Down
5 changes: 4 additions & 1 deletion packages/host/app/components/operator-mode/definition-container/base.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ const BaseContainerHeader: TemplateOnlyComponent<BaseContainerHeaderSignature> =
</Header>
<style scoped>
.base-container-header {
--boxel-header-min-height: 1.56rem;
/* 25px exactly. 1.56rem is 24.96px, and a fractional height
leaves every engine to round it its own way — which is how
the same content lands a pixel apart between browsers. */
--boxel-header-min-height: 1.5625rem;
--boxel-header-padding: var(--boxel-sp-5xs) var(--boxel-sp-xs);
--boxel-header-background-color: var(--boxel-300);
--boxel-header-text-color: var(--boxel-dark);
Expand Down
Loading