Add CodeQL query: WebClient.create without idle timeout (java/vertx/webclient-missing-idle-timeout) - #21
Draft
carlspring with Copilot wants to merge 2 commits into
Draft
Add CodeQL query: WebClient.create without idle timeout (java/vertx/webclient-missing-idle-timeout)#21carlspring with Copilot wants to merge 2 commits into
carlspring with Copilot wants to merge 2 commits into
Conversation
5 tasks
Co-authored-by: carlspring <1436265+carlspring@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement CodeQL rule for WebClient.create without setIdleTimeout
Add CodeQL query: WebClient.create without idle timeout (java/vertx/webclient-missing-idle-timeout)
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a new CodeQL rule detecting
WebClient.createcalls that omit aWebClientOptionswith an explicitsetIdleTimeout, which can leave connections hanging indefinitely and exhaust resources.Query (
WebClientMissingIdleTimeout.ql)Flags two cases:
WebClient.create(vertx)— noWebClientOptionspassed at allWebClient.create(vertx, options)— options passed butsetIdleTimeoutnever called on the variableMetadata:
@id java/vertx/webclient-missing-idle-timeout, severitywarning, security-severity5.0.Supporting files
.qhelp— help file with overview, recommendation, and annotated examplessrc/main/ql/java/.../webclient/)WebClientandWebClientOptionsstubs undersrc/test/ql/test/stubs/io/vertx/ext/web/client/InsecureWebClient.java(expected alert) andSecureWebClient.java(no alert) with.qlref,.expected, andoptionsfiles