SP-925: Add PLATFORM_SERVICE validation layer to config validate#381
Open
Kastriot Salihu (ksalihu) wants to merge 3 commits into
Open
SP-925: Add PLATFORM_SERVICE validation layer to config validate#381Kastriot Salihu (ksalihu) wants to merge 3 commits into
Kastriot Salihu (ksalihu) wants to merge 3 commits into
Conversation
Add PLATFORM_SERVICE as an accepted value of the --layers option on both 'config package validate' and the deprecated 'config validate', and document the new layer in the config command guide. Findings flow through the existing text report and --json output unchanged. Adds spec coverage for the request body, the text report, and the JSON report for the new layer. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Eszter Galicz (celeszter)
previously approved these changes
Jun 17, 2026
| | `PLATFORM_SERVICE` | Platform-service-owned validation — each participating platform service checks the assets it owns against its live service (for example Semantic Layer "list-problems" checks), surfacing platform-level problems that only the running service can detect. Which services take part, and how their findings map to severities, is declared by platform-service descriptors. | Owning platform services (e.g. `cloud-semantic-layer`), coordinated by Pacman | | ||
|
|
||
| Currently `SCHEMA`, `BUSINESS`, and `PACKAGE_SETTINGS` are the layers accepted by the Pacman API. Other values are rejected with a `400 layers.unsupported` error. | ||
| `SCHEMA`, `BUSINESS`, and `PACKAGE_SETTINGS` are accepted by the Pacman API today. `PLATFORM_SERVICE` is the newest layer and is only accepted once platform-service validation is enabled on the validate endpoint. Any value the endpoint does not (yet) support is rejected with a `400 layers.unsupported` error. |
Contributor
There was a problem hiding this comment.
Not sure if having "newest" is an appropriate phrasing in the documentation.
Contributor
Author
There was a problem hiding this comment.
Good call — dropped the "newest" framing (and the related "today"/"(yet)"/"until then" wording) and now describe the layer by its capability and backend-enablement gating instead. Applied to both the summary line and the usage paragraph in 3d6ccb8.
Address review feedback on PR #381: describe the layer by its capability and its backend-enablement gating rather than by relative recency. Removes the "newest"/"today"/"(yet)"/"until then" wording from the validation-layers section of config-commands.md. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the backend-enablement caveats and present PLATFORM_SERVICE alongside the other accepted layers, matching how SCHEMA/BUSINESS/PACKAGE_SETTINGS are documented. The Pacman validate endpoint change lands separately and this PR is merged once it does. Includes-AI-Code: true Co-authored-by: Cursor <cursoragent@cursor.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
PLATFORM_SERVICE(Layer 4: Platform Service Validation, epic SP-866) as an accepted value of the--layersoption onconfig package validateand the deprecatedconfig validatealias.What changed:
PLATFORM_SERVICEin the--layersallowed values and combined example.--jsonwrites the full report. No new branching was needed because the response shape (results[]) is layer-agnostic.docs/user-guide/config-commands.mdgains aPLATFORM_SERVICErow in the layers table, a usage paragraph, updated examples, and theValidationResult.layerunion now includes the new layer.config-validate.spec.tsadds coverage for the request body (combined layers), the text report, and the JSON report forPLATFORM_SERVICE. Full suite green (47 suites / 425 tests).Relevant links
Checklist
Made with Cursor