update undelegated domains#232
Open
masterflitzer wants to merge 1 commit into
Open
Conversation
Author
|
related (same change): serverless-dns/serverless-dns#250 |
ignoramous
requested changes
Jul 5, 2026
| ".example", | ||
| "fritz.box", // github.com/celzero/rethink-app/issues/1298 | ||
| "f.f.ip6.arpa", | ||
| ".fritz.box", // github.com/celzero/rethink-app/issues/1298 |
Contributor
There was a problem hiding this comment.
I don't use Fritz!Box, but isn't fritz.box a fqdn?
Author
There was a problem hiding this comment.
fritz.box is the fqdn of the router yes, but at the same time it is the local domain for the network, a macbook in the network would have a fqdn like macbook-pro.fritz.box for instance
Contributor
There was a problem hiding this comment.
Okay. To allowlist both fritz.box and mac.fritz.box, we'd need 2 entries in this trie:
fritz.box
.fritz.box
Author
|
i replied to your comments @ignoramous, if you want me to change anything let me know :) |
ignoramous
requested changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list updated from dnscrypt-proxy source (https://github.com/DNSCrypt/dnscrypt-proxy/blob/140587c79df3c1edb7fe11fa2f9c135e122e584b/dnscrypt-proxy/plugin_block_undelegated.go#L8)