feat(tags): Add support for asset tagging - #69
Merged
Conversation
Rutvik G (rutvik-gs)
force-pushed
the
feat/tags
branch
from
July 28, 2026 15:01
4ba2741 to
b97b506
Compare
Rutvik G (rutvik-gs)
marked this pull request as ready for review
August 3, 2026 12:35
Ben Schwartz (btschwartz12)
approved these changes
Aug 4, 2026
Matt Farmer (frmrm)
left a comment
Contributor
There was a problem hiding this comment.
leaving a test review to kick the job over
Ben Schwartz (btschwartz12)
force-pushed
the
feat/tags
branch
from
August 4, 2026 14:51
48ce4ab to
a708b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test
1. CRUD
2. Assign / unassign explicit assets
3. Bulk assign (async job)
4. Cancel a running job
If the job finishes first you'll get
Conflict / Tag operation not cancellable(exit 1) instead — expected, just not the happy path.5. Bulk unassign (async job)
6. Guardrails — all rejected before any request, exit 2
7. A tag whose name looks like a UUID
8. Rename and delete