Repository navigation
fix: avoid nil panic when terminating after a failed start - #109
Open
vulragrag-star wants to merge 2 commits into
Open
vulragrag-star wants to merge 2 commits into
vulragrag-star wants to merge 2 commits into
Conversation
If pty.Start fails after a prior successful service run, running could stay true while cmd has a nil Process. The next terminate then nil-dereferenced. Clear running on failed start, nil-guard tty/Process, and mark not running when terminate finishes. Fixes cespare#105
|
感谢您的来信，我尽快回复您！
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
--start-servicecommand fails to start (for example the binary is briefly missing duringgo install),runningcould stay true whilecmdhad a nilProcess. The next restart path calledterminate, which nil-dereferenced.Failed starts now clear
running,terminatenil-guardstty/Process, andterminatemarks the reflex not running when it finishes.Fixes #105
Test plan
go test -count=1 ./...TestTerminateNilSafeAfterFailedStartTestRunCommandFailedStartClearsRunningSigned-off-by: Jason Wang vulragrag@gmail.com