Skip to content

fix(materials): do not record container image digest as tag - #3281

Merged
tknura merged 1 commit into
mainfrom
tknura/sol-68-container-image-tag-digest
Jul 13, 2026
Merged

tknura merged 1 commit into
mainfrom
tknura/sol-68-container-image-tag-digest

Conversation

@tknura

@tknura tknura commented Jul 10, 2026 •

Copy link
Copy Markdown
Member

When a container image material was attested by digest (image@sha256:...), the crafter recorded the digest string in the material's tag field, since ref.Identifier() returns the digest for digest references. The tag then surfaced through the chainloop.material.image.tag annotation and produced malformed pull-by-tag command hints (docker pull image:sha256:...) in the UI.

The tag is now only populated when the reference is an actual tag reference; digest references record no tag. Untagged references still default to latest.

This also fixes tag extraction from the io.containerd.image.name annotation in the OCI layout path, which naively split the reference on : and mistook registry ports and digests for tags. The reference is now parsed with go-containerregistry.

closes https://linear.app/chainloop/issue/sol-68

Review in cubic

Signed-off-by: Tomasz Knura <tomasz.knura@itsilesia.com>
@tknura
tknura requested a review from a team July 10, 2026 08:20

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@tknura
tknura merged commit 780c6cb into main Jul 13, 2026
15 checks passed
@tknura
tknura deleted the tknura/sol-68-container-image-tag-digest branch July 13, 2026 07:56
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
chainloop-cli 1.104.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Bump Helm Chart and Dagger Version => v1.103.1 by @github-actions[bot] in chainloop-dev/chainloop#3259
* fix(ci): align secrets-scan material name with contract by @migmartri in chainloop-dev/chainloop#3262
* fix: harden GitHub Actions workflows against zizmor findings by @migmartri in chainloop-dev/chainloop#3260
* feat: add opencode chainloop-trace plugin by @migmartri in chainloop-dev/chainloop#3267
* ci: bump docker/login-action to v4.4.0 by @matiasinsaurralde in chainloop-dev/chainloop#3261
* fix(controlplane): restrict owner-role invitations to org owners (CP-1) by @migmartri in chainloop-dev/chainloop#3263
* feat: introduce PR mode for attestations by @migmartri in chainloop-dev/chainloop#3268
* docs: fix broken GUAC integration link in README by @tknura in chainloop-dev/chainloop#3272
* fix(cli): correct registered integration add usage string to --opt by @tknura in chainloop-dev/chainloop#3271
* fix: upgrade extras/dagger deps to resolve 4 security advisories by @migmartri in chainloop-dev/chainloop#3277
* fix(crafter): surface auto-discovery validation errors by @waveywaves in chainloop-dev/chainloop#2983
* docs: regenerate CLI reference for registered integration add usage by @matiasinsaurralde in chainloop-dev/chainloop#3279
* fix: upgrade Go toolchain to 1.26.5 for GO-2026-4970-stdlib by @chainloop-platform[bot] in chainloop-dev/chainloop#3278
* feat(cli): explode archive materials in chainloop att add by @javirln in chainloop-dev/chainloop#3254
* fix(materials): do not record container image digest as tag by @tknura in chainloop-dev/chainloop#3281
* fix(cli): accept matching --name and metadata.name in contract commands by @tknura in chainloop-dev/chainloop#3282
* fix(dispatcher): improve fanout delivery timeouts and retry budget by @migmartri in chainloop-dev/chainloop#3270
* refactor: remove the public attribute from workflows by @matiasinsaurralde in chainloop-dev/chainloop#3283
* fix(cli): preserve verbatim contract bytes when splitting apply documents by @javirln in chainloop-dev/chainloop#3233


**Full Changelog**: https://github.com/chainloop-dev/chainloop/compare/v1.103.1...v1.104.0</pre>
  <p>View the full release notes at <a href="https://github.com/chainloop-dev/chainloop/releases/tag/v1.104.0">https://github.com/chainloop-dev/chainloop/releases/tag/v1.104.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!14158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants