Repository navigation
feat(codemod): add field-indicator and map field data attributes - #4310
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Codemod support for the Field move to the Zag machines (#4299).
⛳️ Current behavior (updates)
Field.RequiredIndicatorhas to be replaced by hand, andcss/data-attributesturns[data-scope=field][data-part=input]into[data-field-input], which v6 no longer emits.🚀 New behavior
field-indicatorfor react, solid, svelte and vue:Field.RequiredIndicatorbecomesField.Indicator type="required", closing tag included. A directly importedFieldRequiredIndicatoris reported instead of rewritten.renamePartoption, supported in all three engines.css/data-attributesmaps the fieldinput,textareaandselectparts tocontrol, andrequired-indicatortoindicator.>inside an attribute value or expression no longer cuts the attributes short, and the space before/>is kept.ensurewrites plain string values (type="required") instead of a binding.V6_MIGRATION_GUIDE.mdlist the new transform.🧩 Frameworks
React, Solid, Svelte, Vue (codemod)
💣 Is this a breaking change (Yes/No):
No
📝 Additional information
Vue kebab-case tags (
<field-required-indicator>) aren't matched by any rename rule yet, this one included.