Skip to content

Knowledge notes review screen, in Administration and in Dev tools - #368

Open
cheyras wants to merge 2 commits into
mainfrom
decke/knowledge-review
Open

cheyras wants to merge 2 commits into
mainfrom
decke/knowledge-review

Conversation

@cheyras

@cheyras cheyras commented Oct 26, 2026

Copy link
Copy Markdown
Owner

Phase 6, part two: the screen where reviewers decide the notes agents propose (#358).

  • One component, two mounts
    • /admin/knowledge is an Administration tab for admins.
    • /dev/knowledge is a Dev tools entry for a contributor given knowledge.review. A contributor can never hold admin.access, so /admin is out of reach.
    • Both routes need knowledge.review only. The screen uses its own query, not useAdminQuery, because that requires admin.access.
  • What a reviewer sees
    • Tabs for waiting, approved and rejected notes.
    • Each note's cards, statement, quote and full source link (new tab, noopener noreferrer nofollow), plus the automatic-check flags computed at review time.
    • Approve takes an optional reason. Reject needs one, enforced by the form and by the API.
  • Tests
    • A new browser case at 1280 px runs on cloud and self-host:
      • markup in a note stays text;
      • flags show;
      • the link carries the right rel;
      • a rejection without a reason is not sent;
      • both decisions reach the API with the right body;
      • decided notes move to their tab.
    • The case inventory is updated.
    • Locally: tsc is clean, the web build passes (gated-route precache check included), the web test scripts pass, the shard tests pass and decisions:check passes.

No migration; the API and SQL shipped in #358.

🤖 Generated with Claude Code

https://claude.ai/code/session_015oYErNsTyzvYNppwoipzdY

Phase 6, part two. One component, mounted at /admin/knowledge (an
Administration tab) and /dev/knowledge (a Dev tools entry, for a contributor
given knowledge.review, who never holds admin.access). Waiting, approved and
rejected notes, with cards, statement, quote, the full source link
(noopener noreferrer nofollow) and the automatic-check flags; approve with
an optional reason, reject with a required one. Browser case at 1280 in both
deployments: text stays text, flags show, a reasonless rejection is not
sent, decided notes move tabs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015oYErNsTyzvYNppwoipzdY
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
deckpal Ready Ready Preview Oct 26, 2026 8:56pm UTC

Request Review

github-actions[bot]
github-actions Bot previously approved these changes Oct 26, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically: authored by the repository owner, from a branch in this repo. GitHub forbids self-approval, so this stands in for it (AGENTS.md B12). Required status checks still apply — this does not merge anything.

ConfirmAction gains reasonOptional: the Reason field is shown but not
demanded. The browser case approves one note with a reason and one without
and checks both bodies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015oYErNsTyzvYNppwoipzdY

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically: authored by the repository owner, from a branch in this repo. GitHub forbids self-approval, so this stands in for it (AGENTS.md B12). Required status checks still apply — this does not merge anything.

This branch was successfully deployed

1 active deployment
Preview — a4b5141c Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant