Repository navigation
test: Use a process instead of a thread for the fakeredis server - #304
Merged
Merged
Conversation
ljgray
approved these changes
Sep 22, 2026
Sometimes fakeredis gets stuck if we're not particularly kind to it. This ensures a test will end (by killing the fakeredis process if necessary) instead of hanging forever in a thread-synchronization deadlock.
ketiltrout
force-pushed
the
fakeredis_proc
branch
from
September 23, 2026 20:05
0c96956 to
ef08143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes fakeredis gets stuck if we're not particularly kind to it.
This ensures a test will end (by killing the fakeredis process if necessary) instead of hanging forever in a thread-synchronization deadlock. The trade-off is slower test running.
Because of #303 this won't actually be used in the CI runs on GitHub.