Repository navigation
fix(core): use a separate worker to execute the call-on-start endpoints - #308
Merged
Merged
Conversation
I hadn't appreciated that the Sanic manager wouldn't actually start processes until the "main_process_ready" hook had returned. As a result, calling "_call_endpoints_on_start" at the end of the hook meant that all the call-on-start endpoints would timeout due to the qworker not running while this function was being executed. The solution is to execute "_call_endpoints_on_start" in a separate short-lived Sanic worker (called "init-endpoints"). Then this function will be executed asynchronously to the qworker and is able to wait for the qworker to start-up. This behviour essentially re-creates the pre-upgrade behaviour, where cocod would: 1. start the qworker process 2. execute _call_endpoints_on_start in the main thread 3. hand the main thread over to Sanic
ljgray
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hadn't appreciated that the Sanic manager wouldn't actually start processes until the "main_process_ready" hook had returned. As a result, calling "_call_endpoints_on_start" at the end of the hook meant that all the call-on-start endpoints would timeout due to the qworker not running while this function was being executed.
The solution is to execute "_call_endpoints_on_start" in a separate short-lived Sanic worker (called "init-endpoints"). Then this function will be executed asynchronously to the qworker and is able to wait for the qworker to start-up.
This behviour essentially re-creates the pre-upgrade behaviour, where cocod would: