Repository navigation
feat(endpoint): Support endpoint subdirectories - #314
Merged
Merged
Conversation
For better organization
ljgray
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for better organization; see #160 and https://github.com/chime-experiment/ch_ansible/issues/182
This adds support to
cocodfor grouping endpoints in a full directory tree, rather than forcing them all to be in a single directory. Each endpoint sub-tree may also provide metadata about the tree by putting it in a file called__meta.conf(two underscores). Currently all that's taken from such a file is a description and/or summary for use in the client help strings.Directories which contain no endpoints are ignored.
In the client, each endpoint tree (other that the top-level tree) is represented by a
click.Groupsubclass calledEndpointGroupwhich will recursively create moreEndpointGroups andEndpointCommands as required by the structure given to it.In redis, we represent nested endpoints by replacing directory separators with underscores, so, e.g.
cluster/stopwould becluster_stopin redis. This has the side-effect of meaning we don't allow endpoints named bothalpha/beta_gammaandalpha_beta/gamma. The daemon will detect this sort of (almost certainly unlikely) endpoint name clash and exit with an error if encountered.A redo of #224