Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
ee8e0db
refactor: the folder-file code moves from lib.php to lib.folders.php
chodeus Nov 12, 2026
065a4b6
Merge branch 'fix/folder-write-lock' into refactor/folder-files
chodeus Nov 13, 2026
faa328a
Merge branch 'fix/folder-write-lock' into refactor/folder-files
chodeus Nov 13, 2026
aedf35a
Merge branch 'fix/folder-write-lock' into refactor/folder-files
chodeus Nov 13, 2026
f095bef
chore(release): merge main into beta after v2026.11.14 [skip ci]
chodeus Nov 13, 2026
54221e7
Merge remote-tracking branch 'origin/beta' into refactor/folder-files
chodeus Nov 13, 2026
72fea88
docs: the v2026.11.14 notes list the Unraid 7.4 advanced preview fix …
chodeus Nov 13, 2026
3f21faa
Merge remote-tracking branch 'origin/beta' into refactor/folder-files
chodeus Nov 13, 2026
8c55fcb
docs: the folder-file header says imports and restores replace the fi…
chodeus Nov 13, 2026
59a2386
Merge pull request #174 from chodeus/refactor/folder-files
chodeus Nov 14, 2026
acfe529
fix: a folder action Unraid refuses shows Unraid's reason, not its JS…
chodeus Nov 14, 2026
57ac0ba
fix: a success with an error field stays a success, a null answer is …
chodeus Nov 14, 2026
43c85d1
Merge pull request #184 from chodeus/fix/action-refusal-text
chodeus Nov 14, 2026
071f96c
chore(beta): release changelog
chodeus Nov 14, 2026
90f2c02
ci: the Unraid watch checks what FolderView3 relies on in every suppo…
chodeus Nov 14, 2026
1168627
fix: the Unraid watch reads nested CSS, fails closed on empty input, …
chodeus Nov 14, 2026
d5102ad
docs: the palette's watched reason says the plugin reads its variable…
chodeus Nov 14, 2026
8e04e04
fix: a declaration after a nested rule keeps its place, each theme's …
chodeus Nov 14, 2026
ebb7db4
fix: a watch.json with no contracts, themes or files, or a contract w…
chodeus Nov 14, 2026
14faa05
fix: the CSS comparison keeps !important over a later plain declarati…
chodeus Nov 14, 2026
ae7ff67
fix: the element a selector styles is found past guards nested in :wh…
chodeus Nov 14, 2026
69ca571
fix: a group rule written @media(...) with no space is read, and code…
chodeus Nov 14, 2026
5ce0b4c
Merge pull request #185 from chodeus/ci/unraid-compat
chodeus Nov 14, 2026
d12e462
docs: beta release notes
chodeus Nov 14, 2026
dc8ca2a
Merge branch 'beta' into release/beta
chodeus Nov 14, 2026
6edecf5
Merge pull request #183 from chodeus/release/beta
chodeus Nov 14, 2026
eb17848
chore(release): v2026.11.14.2 [skip ci]
chodeus Nov 14, 2026
16806a0
fix: a failed update no longer deletes the package archive the instal…
chodeus Nov 14, 2026
ce2b149
ci: FolderView3 goes through each supported Unraid's own plugin insta…
chodeus Nov 14, 2026
4903b3f
ci: a dispatched run posts the PHP and Unraid checks on the PR too, a…
chodeus Nov 14, 2026
7d54ebb
chore(deps): update dependency jsdom to v31.0.1 (#187)
renovate[bot] Nov 14, 2026
41a4ca4
ci: deprecations in endpoint child processes fail, a boot starts from…
chodeus Nov 14, 2026
967b87f
ci: a .page's CSS is no JS regex, recovery boots check saved files, a…
chodeus Nov 14, 2026
2522f0a
ci: in a .page, // starts a comment only in its script and PHP blocks…
chodeus Nov 14, 2026
42d87b5
Merge branch 'beta' into ci/unraid-matrix
chodeus Nov 14, 2026
4a8472b
Merge pull request #188 from chodeus/ci/unraid-matrix
chodeus Nov 14, 2026
b16d60a
chore(beta): release changelog
chodeus Nov 14, 2026
eaf0fad
docs: beta release notes
chodeus Nov 14, 2026
8fca425
Merge pull request #189 from chodeus/release/beta
chodeus Nov 14, 2026
6129a29
chore(release): v2026.11.14.3 [skip ci]
chodeus Nov 14, 2026
57eb7f3
ci: FV3's endpoints and pages through each Unraid version's real webGUI
chodeus Nov 14, 2026
44aae4a
ci: page checks see .page warnings, stay inside FV3's part and need t…
chodeus Nov 14, 2026
7a4ef82
ci: the fake Unraid runs Docker and VMs as the Dashboard sees them, w…
chodeus Nov 14, 2026
21f4dfe
ci: comments in the fake Unraid claim only what holds
chodeus Nov 14, 2026
a5b60e9
ci: the fakes refuse forms they do not answer, and each step checks e…
chodeus Nov 14, 2026
3d24811
ci: the fakes refuse every form Unraid does not send, and each step c…
chodeus Nov 14, 2026
ada51de
ci: stand-ins for dmidecode and ip, a missing command fails the run, …
chodeus Nov 14, 2026
c8f4918
ci: the fakes answer each command whole, each read is checked against…
chodeus Nov 14, 2026
e8a8011
ci: the fakes match arguments as the shell split them, and drop forms…
chodeus Nov 14, 2026
d7fece8
Merge pull request #190 from chodeus/ci/unraid-pages
chodeus Nov 14, 2026
a106014
ci: FV3's pages in Chromium and Firefox on every Unraid row, every th…
chodeus Nov 14, 2026
0c5f721
ci: browser checks open folders as a user does, count only members a …
chodeus Nov 15, 2026
532fdc9
ci: a click is dispatched only where Unraid's 7.0 sidebar covers it; …
chodeus Nov 15, 2026
f3436d9
ci: the advanced preview must be visible, fit the window's width and …
chodeus Nov 15, 2026
8b59cc0
Merge pull request #191 from chodeus/ci/unraid-browser
chodeus Nov 15, 2026
515cbd6
ci: an Unraid-alone pass checks every Unraid hook FV3 relies on, and …
chodeus Nov 15, 2026
7c63391
ci: the Unraid-alone pass reads nothing from a page that never drew, …
chodeus Nov 15, 2026
c4d56e1
ci: the Dashboard opens Lab too, Unraid alone must be without FV3, an…
chodeus Nov 15, 2026
0bfe2b7
ci: a Dashboard folder's menu waits for the last one to close, and a …
chodeus Nov 15, 2026
14e6672
ci: a Dashboard folder's menu waits for the last menu's fade to end
chodeus Nov 15, 2026
2fc37a9
ci: a layout failure names the folder even when its name is hidden
chodeus Nov 15, 2026
181e40e
ci: a click waits for its target to stop moving, and a failed click n…
chodeus Nov 15, 2026
3a11551
ci: a tile outside its card is named once
chodeus Nov 15, 2026
63d6fdf
ci: drop the preview line rule: FV3's preview clips an item that does…
chodeus Nov 15, 2026
d77299e
ci: Unraid alone's own browser errors fail its pass too
chodeus Nov 15, 2026
b060ca8
ci: stop when the last run's measurements cannot be removed
chodeus Nov 15, 2026
5ba4a64
fix(error log): log only warnings raised in FV3's own files
chodeus Nov 15, 2026
1209395
fix(error log): comments say what the check tests: files under FV3's …
chodeus Nov 15, 2026
6d8a25a
ci: a function hook must be callable and csrf_token a non-empty strin…
chodeus Nov 15, 2026
030d65b
ci: a hook's expected type lives in HOOKS; a failed js hook names the…
chodeus Nov 15, 2026
e3879ce
Merge pull request #192 from chodeus/ci/unraid-layout
chodeus Nov 15, 2026
d07c654
Merge remote-tracking branch 'origin/beta' into fix/error-log-own-files
chodeus Nov 15, 2026
6c42d02
Merge pull request #193 from chodeus/fix/error-log-own-files
chodeus Nov 15, 2026
db3a3c5
chore(beta): release changelog
chodeus Nov 15, 2026
6c9ad13
docs: beta release notes
chodeus Nov 15, 2026
920fa6f
Merge pull request #194 from chodeus/release/beta
chodeus Nov 15, 2026
8f7ca7f
chore(release): v2026.11.16.1 [skip ci]
chodeus Nov 15, 2026
e84e6d5
fix: keep a saved userprefs.cfg's containers with their folders
chodeus Nov 16, 2026
a2333cd
fix: regroup userprefs.cfg in every autostart mode and on page load
chodeus Nov 16, 2026
f148f89
fix: save a folder's members when none were saved yet; Off never reor…
chodeus Nov 16, 2026
cbd71b5
test: say what the generated-order check counts
chodeus Nov 16, 2026
dc87ff4
fix: Off tooltip says Unraid starts in the autostart file's order
chodeus Nov 16, 2026
e365b37
fix: a container two folders' regexes match goes to the folder the pa…
chodeus Nov 16, 2026
a275ea4
Merge pull request #195 from chodeus/fix/userprefs-follow-folders
chodeus Nov 16, 2026
531efd1
refactor: move the container order code from lib.php into lib.order.php
chodeus Nov 16, 2026
9cd4d47
chore(deps): lock file maintenance (#197)
renovate[bot] Nov 16, 2026
e4e25d1
test: name_order_test.js requires the real lib.order.php; pointers fo…
chodeus Nov 16, 2026
17e431c
style: trim lib.order.php's moved comment blocks to two lines
chodeus Nov 16, 2026
4c92b45
Merge remote-tracking branch 'origin/beta' into refactor/lib-order
chodeus Nov 16, 2026
a13f213
Merge pull request #198 from chodeus/refactor/lib-order
chodeus Nov 16, 2026
f699597
chore(beta): release changelog
chodeus Nov 16, 2026
7bb1264
docs: beta release notes
chodeus Nov 16, 2026
a7f2a26
Merge pull request #196 from chodeus/release/beta
chodeus Nov 16, 2026
3d247d7
chore(release): v2026.11.16.2 [skip ci]
chodeus Nov 16, 2026
a113a16
chore(release): merge v2026.11.16.2 into main for the next stable
chodeus Nov 16, 2026
697710d
chore(main): release changelog
chodeus Nov 16, 2026
302b64f
docs: stable release notes
chodeus Nov 17, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,54 @@ reviews:
GraphQL checks in schema.py; flag a second copy of either.
- TESTS use synthetic versions, shas and handles only; a value captured
from a live system in a fixture is a finding.
- path: ".github/unraid-compat/**"
instructions: |
The Unraid compatibility matrix; CI only, nothing here ships.
- install_test.sh puts the .plg through each Unraid version's own
plugin installer, hooks included, in a fresh Docker container with
no network; it must refuse to run anywhere else (lib.sh's guard).
Only Slackware's upgradepkg and removepkg are stubbed, keeping their
file-list records: flag any other stand-in for Unraid's code.
- fake_unraid.sh serves one Unraid version's real webGUI with php -S
and pages_test.php drives FV3 through it. Stand-ins are what the OS
image adds around the webGUI, nothing of the webGUI itself:
router.php (nginx's locations), prepend.php (php.ini's prepend),
docker.php (dockerd's socket and the docker CLI), libvirt.php (the
php-libvirt extension), rc_service.sh (rc.docker and rc.libvirt),
dmidecode.sh and ip.sh (those commands), connect_state.php (the
Connect plugin), the dockerd and libvirtd
processes, and emhttp's state files (var.ini, network.ini, the
docker and domain cfg). A call a stand-in does not answer fails
the run: flag an answer that hides one, and any stand-in for code
the webGUI repo has.
- browser_test.sh starts fake_unraid.sh in a container with no network
and runs the Playwright image in a second container that joins its
network. browser_test.js drives FV3's Docker, VMs and Dashboard
pages in Chromium and Firefox and checks what the user sees (rows,
tiles, an opened folder, the advanced preview's layout) against
values written by hand. A failed request or console error passes
only for a service the fake does not run (ABSENT) or for Unraid's
own unload handler. Clicks are a user's; only where an element of
Unraid's page frame named in FRAME covers the target is the click
dispatched instead.
fake_logs.php holds the log checks both tests run. package.json
pins playwright-core to the image's version, which
browser_test.sh checks.
- browser_test.sh runs an Unraid-alone pass first, FV3's three
page hooks moved out of its plugin folder. It checks hooks.js, a
hand-written list of Unraid's DOM hooks, functions, stylesheet
classes and endpoints FV3 relies on, each naming the FV3 file that
still mentions it and what the user loses; any/since only where
FV3 itself branches.
layout.js holds the layout rules FV3's pass checks against that
pass and a loose container on the same page, each from a fix FV3
has shipped.
- matrix_check.py keeps ci.yml's Unraid rows at one per minor from the
.plg's min to the newest release; Renovate only moves rows.
- Each step asserts what the user is left with (live files, the
registered manifest, saved folders, Unraid's orders) right after it,
against values written by hand. A failed step fails the job.
- Fixtures hold synthetic names and ids only.
- path: ".github/scripts/**"
instructions: |
CI tests and helpers; nothing here ships in the plugin.
Expand All @@ -224,6 +272,9 @@ reviews:
failed read or download as "nothing to report".
- package.json here is test-only (jquery, jsdom), pinned to exact
versions.
- php_tests.sh is the one list of PHP checks for Lint + build and the
PHP matrix: php -l on every .php and .page file, then every
*_test.php here; a deprecation fails like an error.
- path: "**"
instructions: |-
Applies to every file, whatever the language:
Expand Down
114 changes: 114 additions & 0 deletions .github/scripts/action_refusal_test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
// node .github/scripts/action_refusal_test.js — a folder action Unraid refuses shows Unraid's own reason: the real docker.js and vm.js
// folder actions and shared.js, answered as Unraid's Events.php ({success: true|reason}) and VMajax.php ({success: true}|{error: reason}) answer
'use strict';
const { drawDocker, drawVms, check, done, FOLDER_SETTINGS } = require('./preview_pages_harness.js');

const folder = (name, containers = [], regex = '') => ({ name, containers, regex });
// A VM folder as vm.json holds one
const vmFolder = (name, vms) => ({ name, icon: '', regex: '', containers: vms, settings: { ...FOLDER_SETTINGS }, hidden_preview: [], actions: [] });

// Each action post answered by `answer(data)` (or failed when it returns an Error); the dialogs as the user reads them
const stub = (p, answer) => {
const posts = [];
const dialogs = [];
p.$.post = (url, data) => {
posts.push({ url, data });
const a = answer(data);
return a instanceof Error ? p.$.Deferred().reject({ status: 500, statusText: a.message }) : p.$.Deferred().resolve(a);
};
p.w.swal = (o) => {
const box = p.w.document.createElement('div');
box.innerHTML = String(o.text);
dialogs.push({ title: o.title, lines: box.innerHTML.split('<br>').map((part) => { box.innerHTML = part; return box.textContent; }) });
};
p.w.swal.close = () => {};
return { posts, dialogs };
};

// Runs a folder action to the end on the page's manual clock
const act = async (p, call) => {
let finished = false;
p.g(call).then(() => { finished = true; }, (e) => { p.errors.push(`${call}: ${e && e.stack || e}`); finished = true; });
for (let i = 0; i < 50 && !finished; i++) await p.tick(100);
return finished;
};

(async () => {
const REFUSED = 'Error response from daemon: cannot stop container: web: permission denied';
{
const page = await drawDocker({ folders: { f: folder('Apps', ['web', 'db']) }, containers: ['web', 'db'], prefs: ['folder-f', 'web', 'db'] });
await page.draw();
const { posts, dialogs } = stub(page.p, (data) => (data.container === page.p.g("globalFolders['f'].containers['web'].id") ? { success: REFUSED } : { success: true }));
const finished = await act(page.p, "actionFolder('f', 'stop')");
check("a container Unraid refuses to stop: the dialog shows Unraid's reason, not its JSON answer",
finished && posts.length === 2 && dialogs.length === 1 && dialogs[0].title === 'exec-error' && JSON.stringify(dialogs[0].lines) === JSON.stringify([REFUSED]),
{ finished, posts: posts.length, dialogs, errors: page.p.errors });
}
{
const page = await drawDocker({ folders: { f: folder('Apps', ['web', 'db']) }, containers: ['web', 'db'], prefs: ['folder-f', 'web', 'db'] });
await page.draw();
const { posts, dialogs } = stub(page.p, () => ({ success: true }));
const finished = await act(page.p, "actionFolder('f', 'stop')");
check('every container accepted: no dialog', finished && posts.length === 2 && dialogs.length === 0, { finished, posts: posts.length, dialogs });
}
{
const page = await drawDocker({ folders: { f: folder('Apps', ['web']) }, containers: ['web'], prefs: ['folder-f', 'web'] });
await page.draw();
const { dialogs } = stub(page.p, () => new Error('Internal Server Error'));
const finished = await act(page.p, "actionFolder('f', 'stop')");
check('a request that fails outright is still in the dialog, named by its failure',
finished && dialogs.length === 1 && JSON.stringify(dialogs[0].lines) === JSON.stringify(['Internal Server Error']), { finished, dialogs });
}
{
const NO_NETWORK = "Requested operation is not valid: network 'br0' is not active";
const p = await drawVms({ folders: { v: vmFolder('VMs', ['vm-a', 'vm-b']) }, names: ['vm-a', 'vm-b'], prefs: ['folder-v', 'vm-a', 'vm-b'] });
const { posts, dialogs } = stub(p, (data) => (data.uuid === 'u0' ? { error: NO_NETWORK } : { success: true, state: 'running' }));
const finished = await act(p, "actionFolder('v', 'domain-start')");
check("a VM Unraid refuses to start: the dialog shows libvirt's reason, not the JSON answer",
finished && posts.length === 2 && dialogs.length === 1 && JSON.stringify(dialogs[0].lines) === JSON.stringify([NO_NETWORK]),
{ finished, posts: posts.length, dialogs, errors: p.errors });
}
{
// A success that also carries an `error` field (a warning) is still a success
const p = await drawVms({ folders: { v: vmFolder('VMs', ['vm-a']) }, names: ['vm-a'], prefs: ['folder-v', 'vm-a'] });
const { dialogs } = stub(p, () => ({ success: true, state: 'running', error: 'Waiting for the guest agent' }));
const finished = await act(p, "actionFolder('v', 'domain-start')");
check('an answer that says success and also carries an error field is a success: no dialog', finished && dialogs.length === 0, { finished, dialogs });
}
{
// json_encode of nothing: the action still ends with a dialog instead of throwing with the spinner up
const page = await drawDocker({ folders: { f: folder('Apps', ['web']) }, containers: ['web'], prefs: ['folder-f', 'web'] });
await page.draw();
const { dialogs } = stub(page.p, () => null);
const finished = await act(page.p, "actionFolder('f', 'stop')");
check('a null answer ends the action with a dialog that says the request failed',
finished && !page.p.errors.length && dialogs.length === 1 && JSON.stringify(dialogs[0].lines) === JSON.stringify(['Request failed']), { finished, dialogs, errors: page.p.errors });
}
{
// With the Unraid API (7.2 and later) the action goes to GraphQL first; when that errors, the PHP endpoint's refusal is shown
const page = await drawDocker({ folders: { f: folder('Apps', ['web']) }, containers: ['web'], prefs: ['folder-f', 'web'], api: true });
await page.draw();
const realFetch = page.p.w.fetch;
let mutations = 0;
page.p.w.fetch = async (url, init) => {
if (!String(url).includes('/graphql') || !/mutation/.test(String(init && init.body))) return realFetch(url, init);
mutations++;
return { ok: true, json: async () => ({ errors: [{ message: 'container web: permission denied' }] }) };
};
const { posts, dialogs } = stub(page.p, () => ({ success: REFUSED }));
const finished = await act(page.p, "actionFolder('f', 'stop')");
check("with the API, an action GraphQL refuses goes to Unraid's PHP endpoint once, and its reason is shown",
finished && mutations === 1 && posts.length === 1 && dialogs.length === 1 && JSON.stringify(dialogs[0].lines) === JSON.stringify([REFUSED]),
{ finished, mutations, posts: posts.length, dialogs, errors: page.p.errors });
}
{
// An answer with no reason in it is still a failure, shown as Unraid sent it
const page = await drawDocker({ folders: { f: folder('Apps', ['web']) }, containers: ['web'], prefs: ['folder-f', 'web'] });
await page.draw();
const { dialogs } = stub(page.p, () => ({ success: '' }));
const finished = await act(page.p, "actionFolder('f', 'stop')");
check('an Events.php answer with an empty reason is a failure, not a success',
finished && dialogs.length === 1 && JSON.stringify(dialogs[0].lines) === JSON.stringify(['{"success":""}']), { finished, dialogs });
}
done();
})().catch((e) => { console.error(e); process.exit(1); });
Loading
Loading