Repository navigation
refactor: move the container order code from lib.php into lib.order.php - #198
Conversation
A pure move: 32 functions, each byte-identical, and lib.php requires the new file. lib.php goes from 2,131 to 1,471 lines.
…llow the move The watcher's UserPrefs.php contract and lib.php's require block now point at lib.order.php, whose header names the VM order too.
Seven blocks ran three to nine lines. Each keeps its warning or pointer; the tri-state note moves above fv3_export_order_snapshot, the function it describes. No code line changes.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
@coderabbitai full review |
Action performed
|
server/lib.phpinto a newserver/lib.order.php: userprefs.cfg and FV3's snapshot of it, the autostart file and mode, folder membership, the page order andsyncContainerOrder()(32 functions, Docker and VM).lib.phprequires it beside its otherlib.*.phpfiles.lib.phpgoes from 2,131 to 1,472 lines.name_order_test.jsnow requires the reallib.order.phpinstead of liftingfv3_name_cmpout with a regex; the harness exports its plugin path for it.lib.foreign_import.php.watch.py check. With the newrequire_onceremoved,page_order_test.phpanddocker_saved_places_test.jsfail; the built package holdslib.order.php.Summary by CodeRabbit