Repository navigation
fix(post-process): name each corrupt file and its decoder error in the failure message - #258
Conversation
…e failure message - The Lidarr message listed only the first reason, as ~350 characters of ffmpeg's follow-on lines; it now names each failed file with the decoder's own error, up to 1,000 characters (Pushover's limit is 1,024, Discord's 2,000), then "+N more". - Files keep their disc folder (CD2/01 ...). Slskd strikes showed "(unmapped)" whenever the file did not match its transfer; the name now comes from the file on disk. - A file ffmpeg stopped on only for a damaged tag or cover art says so, not "Audio won't decode". - The first 20 lines of ffmpeg stderr go to the Debug log; the Slskd per-file line is a Warn like the store clients'.
…upt file once - m4a/ALAC lines lose their "[mov,mp4,... @ 0x...]" prefix like the others. - "Audio has decode errors" when ffmpeg decoded to the end; cover-art decoder lines (mjpeg, png, ...) read as "Damaged tag or cover art", not as the audio's failure. - The message lists files by name, and its cut never splits a surrogate pair. - The shared handler logs every failed file, so "+N more (see the Lidarr log)" holds for each client; one spelling for a missing reason.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
@coderabbitai full review |
Action not completed
|
CD2/01 ...). Slskd strikes said "(unmapped)" when the file did not match its transfer; the name now comes from the file on disk.[mov,mp4,...]prefix; old ffmpeg's "Error while decoding stream" is a follow-on line.Summary by CodeRabbit