You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(bandcamp): write MusicBrainz track ids where Lidarr 4.0 keeps them - #259
Lidarr 4.0 (upstream develop, .NET 10) dropped AudioTag.MusicBrainzReleaseTrackId, and its MusicBrainzTrackId now holds the release track id, with the recording in the new MusicBrainzRecordingId. Bandcamp retagging named the dropped property, so on 4.0 every file failed with MissingMethodException and kept the store's tags. That failure was logged only at Debug.
MusicBrainzTrackIds.Set writes both ids to whichever properties the running Lidarr has, so one net8.0 build loads and tags correctly on the current plugins branch and on 4.0. If neither shape is there, it warns once and the rest of the retag still runs.
A failed retag now logs one Warn per download with a count, and each file's error stays at Debug.
Pre-import read-back reads the recording through the plugin's merged TagLib 2.2, which is safe on 4.0. Its tests now write the recording by frame name (MUSICBRAINZ_TRACKID), so a later TagLib 2.5 bump fails them and can't slip through.
Checked on real 4.0 builds (upstream develop ddf8080 and a fork build): plugincheck reports compatible, and Bandcamp retagging writes recording and release track ids that read back right in mp3, flac, m4a, opus, ape, wma and mp2.
Summary by CodeRabbit
Bug Fixes
MusicBrainz recording and release-track IDs are now saved to the appropriate audio tags across supported Lidarr versions, helping preserve accurate track metadata.
Bandcamp downloads continue processing when metadata updates fail for individual files, with a summary warning reporting how many files were affected.
No actionable comments were generated in the recent review.
Walkthrough
The change adds property-shape-aware MusicBrainz ID assignment and uses it during Bandcamp metadata normalization. It also aggregates normalization failure reporting and updates tests for ID assignment and FLAC comment fields.
Changes: MusicBrainz ID compatibility
Layer / File(s)
Summary
ID mapping and validation src/Sleezer/Core/Utilities/MusicBrainzTrackIds.cs, src/Sleezer/Core/PostProcessing/PreImportTagger.cs, tests/Sleezer.Tests/MusicBrainzTrackIdsTests.cs, tests/Sleezer.Tests/Sleezer.Tests.csproj
MusicBrainzTrackIds.Set selects supported string properties to assign recording and release-track IDs. Missing IDs preserve existing values, and unsupported property shapes remain unchanged. Tests cover both property shapes, unsupported shapes, and a FLAC round trip.
Bandcamp uses the helper to assign both IDs. It records per-file normalization failures and logs a warning with the failed and total file counts after processing. The related test writes the recording ID to the MUSICBRAINZ_TRACKID comment field.
This change makes Bandcamp retagging write MusicBrainz track and recording IDs correctly on both older Lidarr and Lidarr 4.0. No merge-blocking issue was found in the supplied changes.
Pre-merge checks: 4
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names the main change: Bandcamp downloads now write MusicBrainz track IDs to the properties that Lidarr 4.0 uses. The changeset adds MusicBrainzTrackIds.Set, which picks the available proper…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: Bandcamp downloads now write MusicBrainz track IDs to the properties that Lidarr 4.0 uses. The changeset adds MusicBrainzTrackIds.Set, which picks the available property shape, and updates BandcampDownloadProxy and PreImportTagger to match. The title is specific and scoped to the primary fix, and it follows conventional-commit style.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioTag.MusicBrainzReleaseTrackId, and itsMusicBrainzTrackIdnow holds the release track id, with the recording in the newMusicBrainzRecordingId. Bandcamp retagging named the dropped property, so on 4.0 every file failed withMissingMethodExceptionand kept the store's tags. That failure was logged only at Debug.MusicBrainzTrackIds.Setwrites both ids to whichever properties the running Lidarr has, so one net8.0 build loads and tags correctly on the currentpluginsbranch and on 4.0. If neither shape is there, it warns once and the rest of the retag still runs.MUSICBRAINZ_TRACKID), so a later TagLib 2.5 bump fails them and can't slip through.Summary by CodeRabbit