ci: [sc-20335] pin setup-go to v7.0.0 so go-version-file takes effect - #7
Merged
Merged
Conversation
The workflow passes go-version-file: go.mod to actions/setup-go@bfdd3570, which is setup-go v2.2.0. That input was added in v3.2.0, so on v2.2.0 it is ignored with an 'Unexpected input(s)' warning, no toolchain is installed, and every job has been building and testing this library with whatever Go the ubuntu-latest image happens to ship rather than the version go.mod declares. Pinned to v7.0.0 (b7ad1dad), keeping the SHA-pinning convention. Checkout already precedes setup-go here, which v3+ requires for go-version-file to resolve the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line CI fix, found while reviewing the same construction in dissig.
The workflow passes
go-version-file: go.modtoactions/setup-go@bfdd3570, which is setup-go v2.2.0. That input was added in v3.2.0. On v2.2.0 it is ignored with anUnexpected input(s)warning, no toolchain is installed, and every run has been building and testing this library with whatever Go theubuntu-latestimage ships instead of the versiongo.moddeclares (1.25.13). A green run has been an accident of the image's default.Pinned to v7.0.0 (
b7ad1dad31e06c5925ef5d2fc7ad053ef454303e), keeping the SHA-pinning convention. Checkout already runs before setup-go in this workflow, which v3+ requires so the action can readgo.modfrom the workspace.Independent of #6 (which touches only
ecies_test.go); either can merge first.Test plan
go.modtoolchain (the "Setup go version spec" log line names 1.25.x) and noUnexpected input(s)warningRefs: sc-20335