Reject malformed scanner audio before storage - #550
Draft
GmcSDLK wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retrospective record
This PR records the RDio scanner fix that was approved and deployed during the 2026-08-08 malformed/empty-audio incident. It is intentionally scoped to the RDio-owned scanner path; no MaydayMon web code, scanner configuration, recordings, databases, or credentials are changed by this PR.
Observed failure
ffmpeg detected MPEG-TS input but reported no usable stream, then failed while writing the ipod/m4a-style output pipe. The previous code logged the ffmpeg error but returned success from conversion, so the controller continued to write and emit the call.
Change
Validation
git diff --checkpassed.Deployment status
Already deployed to RDio before this retrospective PR was opened, following approval. No deployment, restart, configuration change, database change, recording change, or MaydayMon web change is being performed as part of opening this PR.