Repository navigation
fix(build): restrict netns port forwarding to Linux - #11
Merged
Merged
Conversation
unix.Setns/CLONE_NEWNET/SOCK_CLOEXEC are Linux-only, which broke the darwin release cross-compiles. portfw's netns implementation is now build-tagged linux with a clear unsupported-platform error elsewhere, and CI gains a darwin cross-compile step so release-target breakage surfaces in PR checks. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.1.4 release workflow failed on the darwin builds:
unix.Setns/CLONE_NEWNET/SOCK_CLOEXECfrom PR #10 are Linux-only. CI didn't catch it because it only builds Linux.portfwnetns implementation moved behind//go:build linux; other platforms get a clear "not supported on this platform" error.Verified locally:
go buildfor linux/darwin × amd64/arm64 all pass, tests green. v0.1.4 will be re-tagged on the merge commit.🤖 Generated with Claude Code