Repository navigation
fix(debug): cp fallback, tcpdump hint; normalize line endings - #12
Merged
Merged
Conversation
cp used only /proc/<pid>/root, which needs root or process ownership. It now falls back to in-container cat (from) and base64-chunked shell writes (to), handles relative container paths, and reports both attempts on failure. tcpdump failures now carry a needs-root hint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A number of files were committed with CRLF endings, which made gofmt -l flag untouched files. One-time renormalization plus .gitattributes (eol=lf) keeps the tree clean; gofmt applied to the four files with real formatting drift. No functional changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of the debug-toolkit robustness pass, plus repo hygiene:
cp — same
/proc/<pid>/rootprivilege dependency asfshad. Now falls back tocatinside the container (from-container) and base64-chunked writes through the container shell (to-container, works for arbitrary sizes/binary content), anchors relative container paths at/, and failures report both attempts. Unit tests include a 100KB binary round-trip through realsh, plus a live rootless Podman round-trip verified locally.tcpdump — nsenter failures now carry a "requires root — try sudo" hint.
Line endings — 21 files were committed with CRLF, which made
gofmt -lflag untouched files. One-time renormalization +.gitattributes(eol=lf);gofmtapplied to the 4 files with real drift.gofmt -lis now clean repo-wide. No functional changes in that commit.go vet,go test -race, and darwin cross-compile all green.🤖 Generated with Claude Code