Repository navigation
Boxfile: a YAML library panic is a parse error, not a crash - #25
Merged
Merged
Conversation
goccy/go-yaml v1.19.2, the latest release, dereferences nil when a bare "!" tag stands where a list is expected: a Boxfile of "packages: !" took box down. Parse now recovers a panic from the decoder and reports it as an error. Found by FuzzParse on main after chxperiments#17 merged; the input is kept in testdata/fuzz as a seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
fuzz (FuzzParse)failure on main after #17.The fuzzer found that
goccy/go-yamlv1.19.2 (the latest release) panics with a nil dereference when a bare!tag stands where a list is expected. A Boxfile of justpackages: !crashed box.
Parsenow recovers a panic from the decoder and returns it as a parse error.internal/boxfile/testdata/fuzz/FuzzParse/, so it runs as a seed with everygo test.TestParseSurvivesYAMLPaniccovers the minimal inputs.go test -race ./...;FuzzParsefor 3 minutes (~970k execs) with no further crashers.