Repository navigation
Re-fit the view-dependent settings to the camera's zoom step from 2 to 3 - #200
Merged
Merged
Conversation
The zoom went from position 2 to 3 at 08:45 on 2026-10-09 to put more pixels
on a plate at the stop. Measured from a 4K still at each position (ORB
features, RANSAC similarity, 1436/1500 inliers): x1.0556 about frame point
(0.501, 0.480), no rotation; autofocus settled at 97 (was 78) and sharpness is
0.234 (was 0.233).
- GATE_LOCAL_SWEEP_CLOUD_MIN_PLATE_PX default 220 -> 232: every plate is
5.6 % wider, so the same line between approach and stop is 232.
- GATE_EARLY_TRIGGER_PATCH default -> 0,0.248,0.338,0.338: the original
square scaled by the same factor and started at the left edge, so its
thumbnail keeps its 160x90 shape.
- GATE_PLATE_REGION deliberately unchanged: the sweep crops the band at
native 4K and scales it to 1920, so mapping the band outward to the same
scenery would cancel the gain; kept in place it passes the 5.6 % through,
and the ~2.5 % of scenery it gives up at each edge holds no plate position
measured so far.
Recorded in docs/reolink-rlc-811a.md ("Zoom step to position 3"), with the
camera's own detection zone (unchanged), the refocus nudge (now 3 -> 4 -> 3)
and the rollback.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (8)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The camera's zoom was stepped from position 2 to 3 at 08:45 today, to put more pixels on a plate at the stop. The silver pickup (172L66) stops with its plate 197–274 px wide, and on 6 Oct it waited about 50 s with
66misread as68/88/61. Settings fitted to the old view need re-fitting.Measured
A 4K still at each position, matched with ORB features and a RANSAC similarity fit (1436 of 1500 matches were inliers). The analysis recovers a synthetic ×1.06 exactly.
What
GATE_LOCAL_SWEEP_CLOUD_MIN_PLATE_PXdefault 220 → 232 (×1.056).GATE_EARLY_TRIGGER_PATCHdefault →0,0.248,0.338,0.338: the same square, scaled and started at the left edge.GATE_PLATE_REGIONunchanged, on purpose. The sweep crops at native 4K and then scales to 1920. Mapping the band outward would cancel the gain exactly; keeping it in place passes the 5.6 % through. The ~2.5 % of scenery lost at each edge holds no measured plate position.Testing
Full suite 2489 OK (6 skipped). Defaults tests updated deliberately.
🤖 Generated with Claude Code