elf: apply implicit addends to object relocations - #2095
Open
raghav2005 wants to merge 1 commit into
Open
Conversation
R_BPF_64_64 relocations use S + A, with the addend stored in the original LDIMM64 instruction for SHT_REL. Preserve that addend for STT_OBJECT data-section relocations instead of resolving them to S alone. Validate signed addition, 32-bit encoding, and target-section bounds. Add regression coverage for issue cilium#2083, the GCC values[8192] case, and arithmetic edge cases. Signed-off-by: Raghav <raghavawasthi2005@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go test . -run '^TestRelocateDataSectionObjectAddend$' -count=1CGO_ENABLED=1 go test -race . -run '^TestRelocateDataSectionObjectAddend$' -count=1go build ./...go vet ./...go tool staticcheck ./...golangci-lint run --timeout=5m./scripts/go-fix.shFixes #2083