Skip to content

fix(stream): preserve zero reorg settings from API - #85

Open
dumanoglu1 wants to merge 1 commit into
circlefin:mainfrom
dumanoglu1:fix/stream-zero-values
Open

dumanoglu1 wants to merge 1 commit into
circlefin:mainfrom
dumanoglu1:fix/stream-zero-values

Conversation

@dumanoglu1

Copy link
Copy Markdown

Summary

  • Preserve API-returned 0 values for fix_block_reorgs and keep_distance_from_tip instead of converting them to null
  • Move the reorg-setting hydration into a small helper so the zero-value behavior has direct unit coverage
  • Add a regression test for both stream reorg fields when the API returns 0

Fixes #84.

Testing

  • git diff --check
  • go test ./internal/provider -run TestUpdateStreamReorgSettingsFromAPIPreservesZeroValues -count=1 was attempted locally, but Go is not installed in this Windows environment (go command not found).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix_block_reorgs and keep_distance_from_tip set to 0 can produce a permanent Terraform diff

1 participant