Bump tmp and eslint in /javascript - #56
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Removes [tmp](https://github.com/raszi/node-tmp). It's no longer used after updating ancestor dependency [eslint](https://github.com/eslint/eslint). These dependencies need to be updated together. Removes `tmp` Updates `eslint` from 6.6.0 to 10.4.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v6.6.0...v10.4.0) --- updated-dependencies: - dependency-name: tmp dependency-version: dependency-type: indirect - dependency-name: eslint dependency-version: 10.4.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JavaScript example project’s linting toolchain by upgrading ESLint and regenerating the npm lockfile, with the intent of removing now-unneeded transitive dependencies (like tmp) after the ESLint upgrade.
Changes:
- Bumps
eslintinjavascript/package.jsonfrom^6.6.0to^10.4.0. - Updates
javascript/package-lock.jsonto a new dependency graph/format (lockfile v3) consistent with the new ESLint version and its dependency tree.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| javascript/package.json | Updates the top-level ESLint devDependency to v10. |
| javascript/package-lock.json | Regenerates lockfile (v3) and pulls in ESLint v10’s updated dependency tree (including engine/peer dependency metadata). |
Files not reviewed (1)
- javascript/package-lock.json: Generated file
Suppressed comments (1)
javascript/package-lock.json:597
eslint-plugin-import@2.18.2declares a peer dependency oneslint: 2.x - 6.x, which is incompatible with ESLint v10. This will cause peer dependency conflicts and/or broken linting. Upgradeeslint-plugin-import(and any related config packages) to versions compatible with the ESLint major you’re targeting.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+18
to
20
| "eslint": "^10.4.0", | ||
| "eslint-config-airbnb-base": "^14.0.0", | ||
| "eslint-plugin-import": "^2.18.2" |
Comment on lines
+488
to
+490
| "engines": { | ||
| "node": "^20.19.0 || ^22.13.0 || >=24" | ||
| }, |
| "name": "platform-code-examples", | ||
| "version": "1.0.0", | ||
| "lockfileVersion": 1, | ||
| "lockfileVersion": 3, |
Comment on lines
+516
to
+518
| "peerDependencies": { | ||
| "eslint": "^5.16.0 || ^6.1.0", | ||
| "eslint-plugin-import": "^2.18.2" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes tmp. It's no longer used after updating ancestor dependency eslint. These dependencies need to be updated together.
Removes
tmpUpdates
eslintfrom 6.6.0 to 10.4.0Release notes
Sourced from eslint's releases.
... (truncated)
Commits
452c40110.4.0b6417e8Build: changelog update for 10.4.06616856chore: upgrade knip to v6 (#20875)d13b084ci: ensure auto-created PRs run CI (#20860)7e52a71docs: add mention of@eslint-react/eslint-plugin(#20869)e71c7afci: bump pnpm/action-setup from 6.0.5 to 6.0.7 (#20862)544c0c3fix: escape code path DOT labels in debug output (#20866)db3468bdocs: tweak wording around ambiguous CJS-vs-ESM config (#20865)d84393dtest: add unit tests for SuppressionsService.applySuppressions() (#20863)9084664docs: Update READMEMaintainer changes
This version was pushed to npm by eslintbot, a new releaser for eslint since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.