Skip to content

fix(common): add nil safety and normalize version comparison in CheckVersionUpdate #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tyagiquamar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(common): add nil safety and normalize version comparison in CheckVersionUpdate #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77348d
fix(common): add nil safety and normalize version comparison in Check…
Tyagiquamar Sep 4, 2026
6056ce7
Merge branch 'master' into fix/version-check-nil-safety
giornetta Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions common/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package common
import (
"context"
"fmt"
"strings"

"github.com/google/go-github/v57/github"
"github.com/savioxavier/termlink"
Expand Down Expand Up @@ -45,15 +46,16 @@ func GithubClient() *github.Client {
func CheckVersionUpdate() {
ghClient := GithubClient()
res, skip := VersionCheck(ghClient)
if skip {
if skip || res == nil || res.TagName == nil {
return
}

// Check if the version is different from the one in the binary
if res.TagName != nil && *res.TagName != fmt.Sprintf("v%s", VersionCli) {
if res.TagName != nil && *res.TagName != VersionCli {
fmt.Printf("A newer version (%s) is available, please upgrade with \"civo update\"\n", *res.TagName)
}
latest := *res.TagName
latestClean := strings.TrimPrefix(latest, "v")
currentClean := strings.TrimPrefix(VersionCli, "v")

if latestClean != currentClean {
fmt.Printf("A newer version (%s) is available, please upgrade with \"civo update\"\n", latest)
}
}

Expand Down
16 changes: 16 additions & 0 deletions common/common_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,19 @@ func TestVersionCheck(t *testing.T) {
}
})
}

func TestCheckVersionUpdate(t *testing.T) {
t.Run("nil release or tag safety", func(t *testing.T) {
oldCli := VersionCli
defer func() { VersionCli = oldCli }()

VersionCli = "1.0.0"

// Ensure calling with nil handling doesn't panic
res, skip := VersionCheck(github.NewClient(nil))
if skip && res == nil {
// Should return cleanly without panic
CheckVersionUpdate()
}
})
}