feat(launcher): probe ~/Applications for bundles, translate TCC errors - #423
Merged
Conversation
Probe $HOME/Applications/ in addition to /Applications/ for macOS bundle detection (kitty, alacritty, wezterm) and iTerm2 validation. /Applications/ takes precedence when both exist. Translate cryptic macOS TCC/osascript error codes (-1743, -600, -10810) into actionable messages guiding users to System Settings > Privacy & Security > Automation. Created with assistance from Claude 🤖 <claude@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
Match osascript's parenthesized form (-1743) instead of bare -1743 to avoid false positives on -6000/-6001/etc. Lowercase stderr before textual comparison so "Application isn't running" matches real macOS output. Added test for bare code non-match and capital-A text match. Created with assistance from Claude 🤖 <claude@anthropic.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Christopher Collins <collins.christopher@gmail.com>
clcollins
force-pushed
the
srepd/macos-terminal-phase3
branch
from
August 10, 2026 23:12
c82abcc to
e1e3e5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$HOME/Applications/in addition to/Applications/for macOS bundle detection (kitty, alacritty, wezterm) and iTerm2 —/Applications/takes precedence when both exist-1743,-600,-10810) into actionable messages guiding users to System Settings > Privacy & Security > AutomationvalidateTerminalExiststo check both iTerm.app locations before warningdocs/terminals.mddetection section and remove resolved known limitationsTest plan
go test ./pkg/launcher/... -count=1— 4 new detection tests for ~/Applications probinggo test ./pkg/tui/... -count=1— table-driventranslateLoginStderrtests + handler-level TCC guidance testmake test-all— full CI suite passesmake readme-checkpasses (README updated)🤖 Generated with Claude Code