Repository navigation
fix: adjust colspan and fix visibility rules for row - #253
Merged
Merged
Conversation
vini-moret
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #246
Changes proposed in this pull request:
Validate using browser Accessibility tab with accessibility tree 'on'
before: (5 instances of 'row "" Ignored')
after:
Background:
The mobile view will show a heading row above the 2 cell Tier, Credits that consists of the contents of the third column on desktop. That heading row gets hidden for desktop and gets flagged by Siteimprove as empty.
The changes explicitly will set that row to display: none which should fix the defect and prevent screen readers from double-reading that content.
security considerations
None