Repository navigation
Conversation
added 2 commits
August 18, 2026 10:05
Covers config.Load()'s precedence (defaults -> file -> env, including EDS_CONFIG tilde-expansion) and Save()/Load() round-tripping, plus each API client's APIError mapping (error/message/errors response shapes, empty body, request-id header capture) exercised through Do() against httptest.Server. REP-514
golangci-lint's revive (unused-parameter) flagged the httptest handler closures that don't reference their *http.Request argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/config: precedence inLoad()(defaults → file → env),EDS_CONFIGtilde-expansion,Save()/Load()round-trip incl. 0600 permissions.internal/repoapiandinternal/workflowapi:APIErrormapping (error/message/errorsresponse shapes, empty body) and request-id header capture, exercised throughDo()againsthttptest.Server.No
_test.gofiles existed anywhere in the repo before this (make testwas a no-op since the initial commit).REP-514
Test plan
go build ./...go vet ./...go test ./...(21 tests, all passing)gofmt -lclean on the new files