Repository navigation
Conversation
When jemalloc memory profiling was enabled by `_RJEM_MALLOC_CONF="prof:true"`, jemallocs default is start taking profile samples (because prof_active is defaulted to true by jemalloc). Buf if `telemetry.memory_profiler.enabled == false`, foundations did not apply any profiler settings, thus leaving profiling enabled with the default sampling rate of 512KB. This change always applies the settings and adds tests for it. Since testing involves spawning a new process, there's a small binary to help with that.
fisherdarling
approved these changes
Oct 27, 2026
TheJokr
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When jemalloc memory profiling was enabled by
_RJEM_MALLOC_CONF="prof:true", jemallocs default is start taking profile samples (because prof_active is defaulted to true by jemalloc). Buf iftelemetry.memory_profiler.enabled == false, foundations did not apply any profiler settings, thus leaving profiling enabled with the default sampling rate of 512KB.This change always applies the settings and adds tests for it. Since testing involves spawning a new process, there's a small binary to help with that.