Skip to content

Remove 'testing' feature from "production"/default features #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gregor-cf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove 'testing' feature from "production"/default features #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
- uses: Swatinem/rust-cache@v2
- name: Run Clippy
run: |
cargo clippy --all-targets -- \
cargo clippy --all-targets --features testing -- \
-D warnings \
-D unreachable_pub \
-D clippy::await_holding_lock \
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
- name: Install cargo-nextest
uses: taiki-e/install-action@cargo-nextest
- name: Run foundations tests
run: _RJEM_MALLOC_CONF=prof:true cargo nextest run --target ${{ matrix.target }}
run: _RJEM_MALLOC_CONF=prof:true cargo nextest run --features testing --target ${{ matrix.target }}
shell: bash
- name: Run doc tests
run: _RJEM_MALLOC_CONF=prof:true cargo test --doc --target ${{ matrix.target }}
run: _RJEM_MALLOC_CONF=prof:true cargo test --doc --features testing --target ${{ matrix.target }}
6 changes: 3 additions & 3 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

## Build & Test Commands
- Build: `cargo build`
- Test all: `cargo nextest run`
- Test single: `cargo nextest run <test_name>` or `cargo nextest run --test <file> <test_name>`
- Clippy: `cargo clippy --all-targets -- -D warnings -D unreachable_pub -D clippy::await_holding_lock -D clippy::clone_on_ref_ptr`
- Test all: `cargo nextest run --features testing`
- Test single: `cargo nextest run --features testing <test_name>` or `cargo nextest run --features testing --test <file> <test_name>`
- Clippy: `cargo clippy --all-targets --features testing -- -D warnings -D unreachable_pub -D clippy::await_holding_lock -D clippy::clone_on_ref_ptr`
- Format: `cargo fmt --all`
- Lint fix: `./scripts/lint-fix.sh`
- Feature check: `cargo hack check --feature-powerset --no-dev-deps --depth 1`
Expand Down
3 changes: 1 addition & 2 deletions foundations/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ platform-common-default = [
"jemalloc",
"telemetry",
"cli",
"testing",
"settings_deny_unknown_fields_by_default",
"panic_on_frozen_logger",
"panic_on_too_much_logger_nesting",
Expand All @@ -55,7 +54,7 @@ sentry = ["dep:sentry-core", "dep:serde", "dep:governor", "ratelimit", "metrics"

# A subset of features that can be used both on server and client sides. Useful for libraries
# that can be used either way.
server-client-common-default = ["settings", "client-telemetry", "testing"]
server-client-common-default = ["settings", "client-telemetry"]

# Enables serializable documented settings functionality.
settings = [
Expand Down
Loading