Repository navigation
Conversation
TheJokr
reviewed
Oct 28, 2026
| #ident #colon_token ::std::clone::Clone::clone(#ident) | ||
| }, | ||
| ArgMode::ToOwned(_) => quote! { | ||
| #ident #colon_token ::std::borrow::ToOwned::to_owned(#ident) |
Collaborator
There was a problem hiding this comment.
ToOwned has a blanket impl for any T: Clone, I think we can simplify this by using to_owned for all ArgMode::Clone types? (rename the enum variant if you want)
that would make it strictly more powerful than the current released code, and we wouldn't have to add a check for is_unsized (thus also supporting type aliases and custom unsized types).
Author
There was a problem hiding this comment.
pushed a new version, seems smaller and is indeed functionally identical as far as I can tell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of
#[metrics]forces arguments to either beCopyorClone, which for strings forces some unfortunate type signatures (like&String) which are way less ergonomic.This PR adds supports for two common types that implement
ToOwned-strandslice.