fix(banner): quieten and brighten the Banner.Action CTA - #674
Open
AnmolSaini16 wants to merge 2 commits into
Open
fix(banner): quieten and brighten the Banner.Action CTA#674AnmolSaini16 wants to merge 2 commits into
AnmolSaini16 wants to merge 2 commits into
Conversation
`Banner.Action` defaulted to `variant="primary"`, so every banner rendered a saturated filled accent button that overpowered its own message and competed with page-level CTAs. - Default to `variant="secondary"`: an accent-tinted fill with an accent hairline. `variant="primary"` stays available for the rare banner whose CTA is the most important action on the page. - Brighten the `secondary` and `ghost` accents. Labels and icons now use the banner's accent text token directly instead of inheriting the container colour, which picked up the neutral banner's dimmed `text-kumo-default/70` and made the CTA look muddy. - Gate hover colours behind `not-disabled:`, so hover is inert on disabled and loading actions. This also drops the `!important` hovers, since the modifier set now matches Button's own outline defaults and tailwind-merge dedupes them.
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Looks good to me. The updated CTA styling feels more balanced, and the color and hover state adjustments improve clarity while keeping the component consistent with the design system. The changes are clean and well scoped. LGTM.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Banner.Actiondefaulted tovariant="primary", so every banner rendered a saturated filled accent button that overpowered its own message and competed with page-level CTAs.variant="secondary": an accent-tinted fill with an accent hairline.variant="primary"stays available for the rare banner whose CTA is the most important action on the page.secondaryandghostaccents. Labels and icons now use the banner's accent text token directly instead of inheriting the container colour, which picked up the neutral banner's dimmedtext-kumo-default/70and made the CTA look muddy.not-disabled:, so hover is inert on disabled and loading actions. This also drops the!importanthovers, since the modifier set now matches Button's own outline defaults and tailwind-merge dedupes them.