Skip to content

build(kumo): bundle CLI with vp pack - #680

Open
TheAlexLichter wants to merge 10 commits into
cloudflare:mainfrom
TheAlexLichter:build/cli-tsdown
Open

build(kumo): bundle CLI with vp pack#680
TheAlexLichter wants to merge 10 commits into
cloudflare:mainfrom
TheAlexLichter:build/cli-tsdown

Conversation

@TheAlexLichter

@TheAlexLichter TheAlexLichter commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Replace the CLI script that calls esbuild multiple times with a tsdown /
vp pack pass, so no external build script or scaffolding is needed anymore.

This also fully removes esbuild from the toolchain 🎉

Speed is roughly the same (~180ms faster), and output is equivalent.


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: automated reviewer feedback is unavailable; package-output behavior is covered by focused tests
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@680

commit: 47facc1

@github-actions

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 47facc1

@github-actions

Copy link
Copy Markdown
Contributor
Visual Regression Report — 24 changed, 19 unchanged

24 screenshot(s) with visual changes:

Button / Loading State

177 px (0.2%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

361 px (0.41%) changed

Before After Diff
Before After Diff

Dialog / Dialog Sizes

3,082 px (3.48%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

1,728 px (1.95%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

856 px (0.97%) changed

Before After Diff
Before After Diff

Dialog / Custom Max Width

1,043 px (1.18%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

480 px (0.54%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Combobox

480 px (0.54%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Dropdown

130 px (0.15%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Basic

859 px (0.97%) changed

Before After Diff
Before After Diff

Select / Select Sizes

2,926 px (1.8%) changed

Before After Diff
Before After Diff

Select / Select Without Label

91 px (0.1%) changed

Before After Diff
Before After Diff

Select / Select With Description

2,015 px (1.94%) changed

Before After Diff
Before After Diff

Select / Select With Error

1,730 px (1.66%) changed

Before After Diff
Before After Diff

Select / Select Placeholder

1,234 px (1.39%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

196 px (0.22%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

1,300 px (1.47%) changed

Before After Diff
Before After Diff

Select / Select Loading

3,221 px (1.83%) changed

Before After Diff
Before After Diff

Select / Select Complex

181 px (0.17%) changed

Before After Diff
Before After Diff

Select / Select Grouped

105 px (0.12%) changed

Before After Diff
Before After Diff

Select / Select Grouped With Disabled

1,459 px (1.65%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,649 px (1.58%) changed

Before After Diff
Before After Diff

Select (Open)

0 px (0%) changed

Before After Diff
Before After Diff
19 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Button / Link as Button
  • Button / Link with Tooltip
  • Button / Disabled Link
  • Dialog / Dialog Basic
  • Select / Select Multiple
  • Select / Select Disabled Options
  • Select / Select Disabled Items

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant