Repository navigation
Restore the tree construction tests used by the feedback tests. - #347
Merged
Merged
Conversation
The html5lib-tests submodule update in f3093c9 moved to a revision without the `tree-construction` directory, since those tests are now maintained in web-platform-tests (WPT). Because `for_each_test_file()` accepted an empty glob, the feedback tests silently went from 1,809 inputs to the 31 in `tests/data/regression/`, and CI stayed green. We now keep a copy of the tests in `tests/data/tree-construction/`, taken from html5lib-tests 9329e64 (the last revision before they were removed), and `for_each_test_file()` fails when nothing matches. The current WPT version of these tests has five inputs with CDATA sections inside SVG/MathML integration points (e.g. `<svg><title><![CDATA[x]]>`) that we tokenize as bogus comments, so switching to it needs a fix first.
kornelski
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The html5lib-tests submodule update in f3093c9 moved to a revision without the
tree-constructiondirectory, since those tests are now maintained in web-platform-tests (WPT). Because
for_each_test_file()accepted an empty glob, the feedback tests silently went from 1,809 inputsto the 31 in
tests/data/regression/, and CI stayed green.We now keep a copy of the tests in
tests/data/tree-construction/, taken from html5lib-tests9329e64 (the last revision before they were removed), and
for_each_test_file()fails when nothingmatches.
The current WPT version of these tests has five inputs with CDATA sections inside SVG/MathML
integration points (e.g.
<svg><title><![CDATA[x]]>) that we tokenize as bogus comments, soswitching to it needs a fix first.