Repository navigation
Conversation
nnazo
force-pushed
the
nnazo/track-properties
branch
from
October 16, 2026 18:35
c51830d to
805f6d4
Compare
A PUBLISH carrying properties other than DEFAULT_PUBLISHER_PRIORITY and DYNAMIC_GROUPS was refused with NOT_SUPPORTED. Draft 18 requires a relay to cache and forward properties it does not support (Sections 2.5 and 9.6). Accept non-mandatory properties into the track's existing shared state, so downstream SUBSCRIBE_OK and generated PUBLISH carry the complete set. Refuse a PUBLISH with a Mandatory Track Property (0x4000-0x7FFF), at the top level or inside Immutable Properties, with UNSUPPORTED_EXTENSION. Draft 18 registers no supported mandatory type. Refuse unparseable Immutable Properties with MALFORMED_TRACK, which Section 10.6 defines only for FETCH. Neither refusal closes the session or reserves the track's name or alias. Stored immutable bytes stay unchanged. remote: track-properties
A peer's TRACK_STATUS_OK with properties failed to decode because RequestOk had no field for them. Draft 18 ends every REQUEST_OK with Track Properties, populated in TRACK_STATUS_OK (Sections 9.6, 10.5 and 10.14). Carry them after the parameters in RequestOk and both codecs. Empty sets add no bytes, preserving other responses' wire output. Close the session with PROTOCOL_VIOLATION when PUBLISH_OK, PUBLISH_NAMESPACE_OK, SUBSCRIBE_NAMESPACE_OK or REQUEST_UPDATE_OK carries properties, as Section 10.5 requires. Its list omits the SUBSCRIBE_TRACKS response, so that response is sent empty and not checked. BREAKING CHANGE: RequestOk has a new public field, track_extensions, so struct literals no longer compile. RequestOk::new(id, params) builds a response without properties. remote: track-properties
nnazo
force-pushed
the
nnazo/track-properties
branch
from
November 14, 2026 21:24
805f6d4 to
445ad71
Compare
…ties A SUBSCRIBE_OK or FETCH_OK carrying a Mandatory Track Property (0x4000-0x7FFF) was accepted and its track forwarded. Refuse such tracks with Closed(0x33), or Closed(0x12) for unparseable Immutable Properties. Cancel the upstream request and fail pending downstream requests with that code, resetting a fetch stream if data has been forwarded (Sections 2.5.1 and 12.7). Known-value checks read only the first top-level value, and publisher group order was checked only on FETCH_OK. Validate every readable known value on PUBLISH, SUBSCRIBE_OK, TRACK_STATUS_OK and FETCH_OK before track-scoped refusal, closing the session for out-of-range values. Search Immutable Properties one level deep in the typed getters, with mutable values taking precedence. An immutable default priority applies to the track's subgroups and datagrams; immutable bytes stay unchanged. remote: track-properties
nnazo
force-pushed
the
nnazo/track-properties
branch
from
November 14, 2026 21:32
445ad71 to
b20c7b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relays built on moq-transport now forward Track Properties. Until now moq-relay-ietf dropped them: every downstream SUBSCRIBE_OK went out with an empty set, a PUBLISH carrying any property other than DEFAULT_PUBLISHER_PRIORITY was refused with NOT_SUPPORTED, and generated PUBLISH and TRACK_STATUS_OK carried none. Draft 18 requires a relay to cache and forward properties it does not understand, and to include them in PUBLISH, SUBSCRIBE_OK, TRACK_STATUS_OK and FETCH_OK (sections 2.5 and 9.6).
The served track now holds the property set it received from upstream SUBSCRIBE_OK or inbound PUBLISH, so cache hits and rendezvous releases send the same bytes as the first answer. Values are kept as received, including the inner bytes of Immutable Properties. The four commits add this per message, then handle Mandatory Track Properties (section 2.5.1) and the value limits in sections 12.4 to 12.6, searching Immutable Properties as section 12.7 requires.
RequestOkgains a publictrack_extensionsfield, so struct literals no longer compile.RequestOk::new(id, params)builds one without properties. Messages without properties are unchanged on the wire.Four items where draft 18 is silent or ambiguous, and what this change does:
A Mandatory Track Property sent as an Object Property (section 2.5.1) is not handled yet; that is data-path work for a follow-up.