Skip to content

fix(release): drop versions from workspace dev-dependencies - #309

Merged
englishm merged 1 commit into
cloudflare:mainfrom
englishm-cloudflare:me/path-only-dev-deps
Nov 2, 2026
Merged

englishm merged 1 commit into
cloudflare:mainfrom
englishm-cloudflare:me/path-only-dev-deps

Conversation

@englishm-cloudflare

Copy link
Copy Markdown
Contributor

The release job after #308 published moq-transport 0.17.0, moq-native-ietf 0.11.0 and moq-relay-ietf 0.8.0, then failed on moq-pub:

failed to publish moq-pub: failed to select a version for the requirement `moq-sub = "^0.5"`

moq-pub's dev-dependency on moq-sub had a version requirement, so cargo needed moq-sub 0.5 to be on crates.io before it would package moq-pub, and release-plz hadn't published moq-sub yet. moq-clock-ietf's dev-dependency on moq-relay-ietf has the same constraint, although that one happened to be satisfied.

This removes the version requirement from both workspace dev-dependencies. Cargo strips path-only dev-dependencies from the published manifest, so the publish order no longer matters for them. cargo package -p moq-pub and -p moq-clock-ietf now succeed against the current index.

Once this merges, the release job should publish the remaining versions from #308: moq-pub 0.10.0, moq-sub 0.5.0, moq-clock-ietf 0.6.25 and moq-test-client 0.2.0.

moq-pub's dev-dependency on moq-sub carried a version requirement, so
publishing moq-pub 0.10.0 failed: cargo looked up moq-sub ^0.5 on
crates.io before release-plz had published it. Workspace dev-dependencies
only need a path; cargo strips path-only dev-dependencies from the
published manifest, which also removes the publish-order constraint for
moq-clock-ietf's dev-dependency on moq-relay-ietf.
@englishm
englishm marked this pull request as ready for review November 2, 2026 18:29
@englishm
englishm merged commit 9135c3e into cloudflare:main Nov 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants