Repository navigation
fix(release): drop versions from workspace dev-dependencies - #309
Merged
englishm merged 1 commit intoNov 2, 2026
Merged
Conversation
moq-pub's dev-dependency on moq-sub carried a version requirement, so publishing moq-pub 0.10.0 failed: cargo looked up moq-sub ^0.5 on crates.io before release-plz had published it. Workspace dev-dependencies only need a path; cargo strips path-only dev-dependencies from the published manifest, which also removes the publish-order constraint for moq-clock-ietf's dev-dependency on moq-relay-ietf.
englishm
marked this pull request as ready for review
November 2, 2026 18:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job after #308 published moq-transport 0.17.0, moq-native-ietf 0.11.0 and moq-relay-ietf 0.8.0, then failed on moq-pub:
moq-pub's dev-dependency on moq-sub had a version requirement, so cargo needed moq-sub 0.5 to be on crates.io before it would package moq-pub, and release-plz hadn't published moq-sub yet. moq-clock-ietf's dev-dependency on moq-relay-ietf has the same constraint, although that one happened to be satisfied.
This removes the version requirement from both workspace dev-dependencies. Cargo strips path-only dev-dependencies from the published manifest, so the publish order no longer matters for them.
cargo package -p moq-puband-p moq-clock-ietfnow succeed against the current index.Once this merges, the release job should publish the remaining versions from #308: moq-pub 0.10.0, moq-sub 0.5.0, moq-clock-ietf 0.6.25 and moq-test-client 0.2.0.