Repository navigation
fix: let an authored canonical replace the page's own - #307
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-authored-canonical.nimbus-docs.com (commit adbb51d)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<link rel="canonical">authored in a page's or the site'sheadis now the page's only canonical. Nimbus no longer emits its own beside it.og:urland the structured data'surlfollow the authored canonical.site, withbaseadded once, the waysocialImageis.Before → after
No config, API, type or user-owned file changes. Pages that author no canonical are unchanged. A route that computes a canonical passes it as a
headelement.Checks
pnpm --filter @cloudflare/nimbus-docs typecheck: passpnpm lint: passtest/head-seo-build.test.ts(4 tests, with new assertions for an absolute canonical, a site path, a site path underbase, and pages without one): pass. The new assertions fail onmainwith two canonical links.test/api-query-versions-build.test.ts,test/api-page-assets-build.test.ts(the other head assertions): pass