Repository navigation
feat: add skill feedback reference to every skill - #249
Merged
Merged
Conversation
When a skill gives incorrect, outdated, or missing guidance, agents had no instructions for reporting it, so the problem stayed with the user. Each skill now includes references/skill-feedback.md, which tells the agent to ask the user, draft a GitHub issue on cloudflare/skills with a structured field table, review it with the user, and post it with a `skill-feedback: <skill>:` title prefix. Each SKILL.md links to it. The reference is copied into every skill because skills can be installed individually.
MattieTK
requested review from
dmmulroy,
irvinebroque and
kale-stew
as code owners
October 27, 2026 16:26
kale-stew
reviewed
Oct 27, 2026
kale-stew
left a comment
Member
There was a problem hiding this comment.
Nice addition, and the per-skill copies make sense given skills install individually. I checked that all 19 SKILL.md files link the reference exactly once and that each copy names its own skill; the copies are otherwise identical, so the two comments below apply to every references/skill-feedback.md.
Both are about the one irreversible step here: posting conversation-derived content to a public issue.
- The only data guidance is the general reminder on line 3. Since step 2 drafts the body from the conversation, it would help to name what must never go in: credentials or tokens, account or zone IDs, customer or personal data, internal hostnames or URLs, and private code.
- Line 3 says to review the submission with the user, but the numbered steps go straight from drafting (step 2) to
gh issue create(step 3). An agent following the steps can read the step 1 "yes" as approval to post text the user hasn't seen. A separate step that shows the exact title and body and asks for confirmation would close that gap.
Reviewed at 0e09df4.
The steps went from drafting straight to `gh issue create`, so an agent could treat the user's agreement to send feedback as approval to post text they had not seen. Add a review step that shows the exact title and body and asks a yes/no question before submitting. Also list what must not go into a public issue (credentials, resource IDs, personal data, internal hostnames, private code) and make the opening reminder firmer.
kale-stew
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a skill gives incorrect, outdated, or missing guidance, agents have no instructions for reporting it to the maintainers. This adds a short reference that lets an agent turn that report into a GitHub issue, with the user's agreement.
Changes
references/skill-feedback.md. It tells the agent to:cloudflare/skillswith askill-feedback: <skill>: <summary>titleissues/newlink if submission failsSKILL.mdends with a## Skill feedbacksection that links to the reference.The reference is copied into every skill rather than shared, because skills can be installed individually (for example with
npx skillsor by copying folders). Each copy contains its own skill name so issues can be triaged by skill.The
skill-feedback:prefix makes these issues searchable without new labels or issue templates. We can add those later if the volume justifies it.Testing
python3 .github/scripts/check-reference-code-blocks.pyreports no warnings for the new files.python3 -m unittest discover -s skills/turnstile-spin/tests).SKILL.mdlinks to an existingreferences/skill-feedback.mdexactly once, and that the copies differ only in the skill name.