[npaun]

Applies to:

• temporal_capi
• icu4x and friends

Kind of involved, but I think it's ok

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.38%. Comparing base (fb27a83) to head (d797e6c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8058      +/-   ##
==========================================
- Coverage   69.38%   69.38%   -0.01%     
==========================================
  Files         696      696              
  Lines      181896   181896              
  Branches    29221    29221              
==========================================
- Hits       126212   126209       -3     
- Misses      38610    38613       +3     
  Partials    17074    17074              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[clanky-the-clanker]

✅ Approved — The last review's WARNING (the Bazel crate lockfile wasn't regenerated) and its smaller notes are fixed at this commit, and there are no new issues.

_{The decision is advisory: this comment never approves, blocks or requests changes on the pull request.}

---

✅ All checks passed

🔒 Security: ✅ LGTM

The helper fetches from fixed HTTPS URLs and passes cargo and bazel their arguments as lists, without a shell.

---

📖 AGENTS.md: ✅ LGTM

No AGENTS.md update is needed. docs/v8-updates.md covers the new step, and AGENTS.md already links to it.

---

📋 Code Quality: ✅ LGTM

• The helper now repins cargo-bazel-lock.json with bazel fetch --repo_env=CARGO_BAZEL_REPIN=1 --repo=@crates_vendor (ci/v8_update.py:139-143), and the tests cover it.
• Cargo's stderr now shows when --precise is refused, and the final error says how to fix each crate that doesn't match.
• _exact_pins reads Cargo.toml with tomllib, and cargo add updates the pins.
• The repository's Python toolchain is 3.13, so tomllib is available to the new py_test.

---

⚡ Performance: ✅ LGTM

This is an offline maintenance script and doesn't touch any hot path.

---

📝 Documentation: ✅ LGTM

The docs and the caret-compatibility comment now match the code.

---

_{Reviewed commit: d797e6c2 — same changes as 0accb61c, so this is that commit's review (no new review was run; line numbers are as of 0accb61c)}

[ask-bonk]

Since last review: 1 resolved, 0 still open, 2 new.

Automates Chromium Rust dependency alignment, adds Bazel tests, and documents the V8 update workflow.

---

_{Reviewed commit: 0accb61c · github run}

[logan-gatlin]

Instead of writing back to the Cargo.toml you could run cargo add 'dep@x.y.z', it edits the file in place, keeps all features, just repins the version to what you want

[npaun]

improved it... still needs one more round of deslopping imo