[fhanau]

This was left out of the weekly deps update. Also updating the Rust version while we're at it

[clanky-the-clanker]

💬 Approved with comments — No problems found. The new cargo toolchain definitions and their registrations line up. Several files that had not changed since the last approved review were not re-checked this time.

Findings: 1 info

_{The decision is advisory: this comment never approves, blocks or requests changes on the pull request.}

---

📋 Code Quality: 💬 1 info

No defects. Files unchanged since the last review were not re-checked.

Recommendation: 💬 Optional Nits

• [INFO] This pass did not re-check these files for correctness, which the last review had approved: build/deps/formatters/rustfmt_repository.bzl, build/deps/gen/build_deps.MODULE.bazel, deps/rust/Cargo.toml, patches/rules_rust/0001-Propagate-coverage-info-through-link_deps.patch and src/rust/cxx/kj-hyper/tls.rs.

View full review

• New cargo toolchain (build/rust/sanitizer_toolchain.bzl:151-168): it moves the cargo label out of rust_toolchain() and uses the same constraints and nightly settings as the sanitizer rust toolchain.
• Registrations in .bazelrc: every name matches a toolchain the macro defines.
  • asan: linux_x86_64, linux_aarch64 and macos_aarch64.
  • tsan: linux_x86_64 and macos_aarch64.
• Not checked: no build was run, so this review did not confirm that cargo_toolchain loads at the pinned rules_rust version.

---

✅ All other checks passed

🚀 Release: ✅ LGTM

No release concerns. This pull request only updates build tooling and dependencies.

---

🔒 Security: ✅ LGTM

No security concerns. The certificate checks in tls.rs are unchanged apart from the x509-cert 0.3 accessor API.

---

📖 AGENTS.md: ✅ LGTM

No AGENTS.md updates needed.

---

⚡ Performance: ✅ LGTM

The changes are dependency bumps, toolchain registration and a build-time tweak. The new cargo toolchain registrations only affect the asan and tsan configs.

---

📝 Documentation: ✅ LGTM

No documentation concerns.

---

_{Reviewed commit: 070c8774 — same changes as d9092ab3, so this is that commit's review (no new review was run; line numbers are as of d9092ab3)}

[ask-bonk]

Since last review: 0 resolved, 0 still open, 0 new.
LGTM!

Not re-run: compat-flags, memory-safety, rust-first (no author changes in their files since the last review)

---

_{Reviewed commit: 070c8774 · github run}

[github-actions]

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

[fhanau]

The rust version update turned out to be too much for this PR, I dropped it for now (several new clippy lints where I don't like the default resolution)

[ask-bonk]

Author identity unknown

*** Please tell me who you are.

Run

git config --global user.email "you@example.com"
git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for runner@runnervm48cm3.r3gv55co0vserpzgji3gvzdlob.gx.internal.cloudapp.net) not allowed

github run

[ask-bonk]

Author identity unknown

*** Please tell me who you are.

Run

git config --global user.email "you@example.com"
git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for runner@runnervm48cm3.r3gv55co0vserpzgji3gvzdlob.gx.internal.cloudapp.net) not allowed

github run

[ask-bonk]

Author identity unknown

*** Please tell me who you are.

Run

git config --global user.email "you@example.com"
git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for runner@runnervm48cm3.r3gv55co0vserpzgji3gvzdlob.gx.internal.cloudapp.net) not allowed

github run

[ask-bonk]

@fhanau Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

[fhanau]

Had to add another commit to solve issues with the sanitizer toolchain (as in the reason we didn't include rules_rust in the weekly update)