Repository navigation
wrangler: fix: support the deletion of secrets with complex names - #10668
Merged
petebacondarwin merged 1 commit intoSep 25, 2025
Merged
petebacondarwin merged 1 commit into
petebacondarwin merged 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 22f2347 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
danielrs
force-pushed
the
drivas/wrangler-secret-names-url-encoded
branch
from
September 16, 2025 06:33
e59d663 to
243f9ab
Compare
Contributor
|
should we do this for the other 3 secret endpoints as well? |
for-the-kidz
approved these changes
Sep 16, 2025
Contributor
Author
|
Contributor
Author
Wrangler does not do |
danielrs
force-pushed
the
drivas/wrangler-secret-names-url-encoded
branch
from
September 17, 2025 20:33
243f9ab to
29b912e
Compare
dario-piotrowicz
approved these changes
Sep 19, 2025
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
Member
There was a problem hiding this comment.
lgtm 🙂 (with a couple of small suggestions)
danielrs
force-pushed
the
drivas/wrangler-secret-names-url-encoded
branch
from
September 19, 2025 20:43
1ddccc9 to
ca2e23d
Compare
URL encode the secret names before being sent to the API, should allow users to delete secrets with complex names. Change is still compatible with older Wrangler versions thanks to the optional query param flag `url_encoded`.
petebacondarwin
force-pushed
the
drivas/wrangler-secret-names-url-encoded
branch
from
September 25, 2025 13:56
ca2e23d to
22f2347
Compare
Contributor
|
Interestingly the |
petebacondarwin
approved these changes
Sep 25, 2025
Contributor
|
Since this is a patch (bug-fix) then it should indeed be backported to V3. |
Contributor
|
The reason why the CI job to autocreate that backport failed is because this PR is from a fork. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL encode the secret names before being sent to the API, should allow users to delete secrets with complex names. Change is still compatible with older Wrangler versions thanks to the optional query param flag
url_encoded.Tracking internally: https://jira.cfdata.org/browse/WC-3991
Describe your change...
URL encode all secret names in the
DELETE .../secrets/:secretcall, should allow the deletion of secrets with complex names.Docs have new query param
url_encoded:https://developers.cloudflare.com/api/resources/workers/subresources/scripts/subresources/secrets/methods/delete/