Improve error logging

[penalosa]

Fixes DEVX-2213

Previously, the formatMessage utility was heavily used across the Wrangler codebase to nicely format ParseError-style error messages. This led to nice display, but had two problems:

• It was used via logger.log(formatMessage(...)), which meant that a large chunk of Wrangler's error messages were shoing up in stdout rather than stderr
• It needed to be used intentionally, which meant that in various places we logged out a potentional ParseError without applying the formatting (leading to hard to understand stack traces being shown to users when e.g. a preview session failed)

Now, logger.error() will automatically apply formatMessage() when the first argument is a ParseError

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: internal refactor
• Wrangler V3 Backport
  • Wrangler PR: V3 backport #10734 #10782
  • Not necessary because:

[changeset-bot]

🦋 Changeset detected

Latest commit: 46d8a85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[penalosa]

I think this is a bug. As such, I've changed this equality check, and inverted the callsites of isAbortError(), which seems to make more sense to me.

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10734

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10734

miniflare

npm i https://pkg.pr.new/miniflare@10734

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10734

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10734

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10734

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10734

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10734

wrangler

npm i https://pkg.pr.new/wrangler@10734

commit: 46d8a85

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/improve-error-logging might be a good starting point.

Notes:

• your PR branch should be named v3-backport-10734
• add the skip-v3-pr label to the current PR to stop this workflow from failing