Skip to content

switch zone route warning to an info message #10761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petebacondarwin merged 1 commit into from
Oct 1, 2025
Merged

switch zone route warning to an info message #10761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/puny-coins-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

switch zone route warning to an info message
10 changes: 1 addition & 9 deletions packages/wrangler/src/__tests__/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,15 +1539,7 @@ describe("deploy", () => {

expect(std.err).toMatchInlineSnapshot(`""`);
expect(std.warn).toMatchInlineSnapshot(`
"▲ [WARNING] The current authentication token does not have 'All Zones' permissions.

Falling back to using the zone-based API endpoint to update each route individually.
Note that there is no access to routes associated with zones that the API token does not have
permission for.
Existing routes for this Worker in such zones will not be deleted.


▲ [WARNING] Previously deployed routes:
"▲ [WARNING] Previously deployed routes:

The following routes were already associated with this worker, and have not been deleted:
Comment on lines 1540 to 1552

@edmundhung edmundhung Sep 30, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a snapshot test for std.info?

@petebacondarwin petebacondarwin Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! I merged this too soon. Yes you are right.

- \\"foo.example.com/other-route\\"
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/src/deploy/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ async function publishRoutesFallback(
{ telemetryMessage: true }
);
}
logger.warn(
logger.info(
"The current authentication token does not have 'All Zones' permissions.\n" +
"Falling back to using the zone-based API endpoint to update each route individually.\n" +
"Note that there is no access to routes associated with zones that the API token does not have permission for.\n" +
Expand Down
Loading