Skip to content

chore: stop mocking wrangler banner by default - #10868

Merged
edmundhung merged 5 commits into
mainfrom
edmundhung/stop-mocking-banner
Oct 3, 2025
Merged

edmundhung merged 5 commits into
mainfrom
edmundhung/stop-mocking-banner

Conversation

@edmundhung

Copy link
Copy Markdown
Member

Fixes n/a.

This removes the default wrangler banner mock in packages/wrangler/src/__tests__/vitest.setup.ts to make it more visible on whether the banner is print in json output.

Ref: #10822 (comment)


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because:
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because:

@edmundhung
edmundhung requested a review from a team as a code owner October 3, 2025 14:58
@edmundhung edmundhung added the ci:skip-pr-description-validation Skip validation of the required PR description format label Oct 3, 2025
@edmundhung
edmundhung requested review from a team as code owners October 3, 2025 14:58
@edmundhung edmundhung added the ci:no-changeset-required Skip pull request checks for a valid changeset label Oct 3, 2025
@edmundhung
edmundhung requested a review from a team as a code owner October 3, 2025 14:58
@changeset-bot

changeset-bot Bot commented Oct 3, 2025 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b5897ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 3, 2025 •

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10868

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10868

miniflare

npm i https://pkg.pr.new/miniflare@10868

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10868

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10868

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10868

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10868

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10868

wrangler

npm i https://pkg.pr.new/wrangler@10868

commit: b5897ba

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Oct 3, 2025
@edmundhung
edmundhung merged commit e7484f3 into main Oct 3, 2025
34 of 35 checks passed
@edmundhung
edmundhung deleted the edmundhung/stop-mocking-banner branch October 3, 2025 17:09
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Oct 3, 2025
Success! Uploaded mTLS Certificate
ID: 1234
Issuer: example.com...
Expires on 10/3/2026"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are definitely going to break (like today!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset ci:skip-pr-description-validation Skip validation of the required PR description format

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants