Skip to content

[C3] Bump create-astro from 5.2.6 to 5.3.0 in /packages/create-cloudflare/src/frameworks - #16342

Merged
petebacondarwin merged 3 commits into
mainfrom
dependabot/npm_and_yarn/packages/create-cloudflare/src/frameworks/create-astro-5.3.0
Oct 18, 2026
Merged

petebacondarwin merged 3 commits into
mainfrom
dependabot/npm_and_yarn/packages/create-cloudflare/src/frameworks/create-astro-5.3.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Bumps create-astro from 5.2.6 to 5.3.0.

Release notes

Sourced from create-astro's releases.

create-astro@5.3.0

Minor Changes

Patch Changes

  • #18218 acc0460 Thanks @​KTrain5169! - create-astro no longer places a CLAUDE.md in projects, as Claude Code now supports AGENTS.md.
Changelog

Sourced from create-astro's changelog.

5.3.0

Minor Changes

Patch Changes

  • #18218 acc0460 Thanks @​KTrain5169! - create-astro no longer places a CLAUDE.md in projects, as Claude Code now supports AGENTS.md.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Devin Review

Bumps [create-astro](https://github.com/withastro/astro/tree/HEAD/packages/create-astro) from 5.2.6 to 5.3.0.
- [Release notes](https://github.com/withastro/astro/releases)
- [Changelog](https://github.com/withastro/astro/blob/main/packages/create-astro/CHANGELOG.md)
- [Commits](https://github.com/withastro/astro/commits/create-astro@5.3.0/packages/create-astro)

---
updated-dependencies:
- dependency-name: create-astro
  dependency-version: 5.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot requested a review from workers-devprod as a code owner October 18, 2026 06:06
@dependabot dependabot Bot added ci:skip-pr-description-validation Skip validation of the required PR description format dependencies Used by dependabot to mark PRs as updates to dependencies. package:c3 Relating to C3 (create-cloudflare) package labels Oct 18, 2026
@changeset-bot

changeset-bot Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ba88f26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Oct 18, 2026
@workers-devprod
workers-devprod requested review from a team and jamesopstad and removed request for a team October 18, 2026 06:07
@workers-devprod

workers-devprod commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]

This comment was marked as resolved.

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

💬 Approved with comments — This is a clean dependency bump. Both Astro templates now declare the Node.js >=22.22.0 requirement, and tests cover it. The only comment is a small wording fix in the changeset.

Findings: 1 suggestion

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.

🔧 Fix with your agent

Paste the following into your coding agent to investigate and fix these issues.

Fix the following code review issues found in pull request #16342.

Before making changes, review each issue and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g., the fix would require disproportionate changes
  for minimal ROI, or the finding is factually incorrect), explain why
- If you need to clarify something before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order

## SUGGESTION (1)

### [Documentation] Changeset says C3 explains the Astro upgrade for every Node.js version below 22.22.0. Versions below C3's own minimum are stopped first by bin/c3.js:40-47, which only reports C3's minimum. Limit the claim to C3-supported versions or mention both minimums.
- **File:** .changeset/c3-frameworks-update-16342.md:5

📝 Documentation: 💬 1 suggestion

The changeset wording overstates which Node.js versions get Astro's upgrade message

Recommendation: 💬 Optional Nits

  • [SUGGESTION] Changeset says C3 explains the Astro upgrade for every Node.js version below 22.22.0. Versions below C3's own minimum are stopped first by bin/c3.js:40-47, which only reports C3's minimum. Limit the claim to C3-supported versions or mention both minimums. (.changeset/c3-frameworks-update-16342.md:5)
View full review

.changeset/c3-frameworks-update-16342.md:5 says that C3 explains the Astro upgrade requirement whenever Node.js is older than 22.22.0. That is not true for every version:

  • Node.js versions below C3's own minimum (MIN_NODE_VERSION) are stopped earlier by the check in packages/create-cloudflare/bin/c3.js:40-47.
  • That check only reports C3's own minimum. A user who upgrades just to that version still won't meet Astro's 22.22.0 requirement.

Consider saying the message applies to Node.js versions C3 supports, or mention both minimums. This is changelog wording only and does not affect runtime behaviour.


✅ All other checks passed

📋 Code Quality: ✅ LGTM

The bump to create-astro 5.3.0 matches its new minimum Node.js version of 22.22.0.

  • Templates: frameworkCliNodeVersion: ">=22.22.0" is added to both the Pages and Workers Astro templates. This field is already declared in src/templates.ts and read in src/frameworks/index.ts, and the Nuxt templates use it the same way.
  • Tests: the new tests cover both platform variants, with Node.js versions just below the minimum and at or above it.

This review did not cover the lockfile changes, and the tests were not run.


Reviewed commit: ba88f269

The following dependency versions have been updated:

| Dependency   | From  | To    |
| ------------ | ----- | ----- |
| create-astro | 5.2.6 | 5.3.0 |
devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@16342

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@16342

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@16342

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@16342

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@16342

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@16342

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@16342

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@16342

miniflare

npm i https://pkg.pr.new/miniflare@16342

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@16342

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@16342

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@16342

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@16342

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@16342

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@16342

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@16342

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@16342

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@16342

wrangler

npm i https://pkg.pr.new/wrangler@16342

commit: ba88f26

@petebacondarwin petebacondarwin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The create-astro 5.3.0 package raises its Node.js minimum from >=22.12.0 to >=22.22.0, while C3 accepts Node >=22.0.0 and neither Astro template sets frameworkCliNodeVersion. This newly breaks Astro scaffolding on Node 22.12–22.21. Please add a compatible generator selection or a version gate/fallback for both Astro templates, with boundary coverage, before merging.

@github-project-automation github-project-automation Bot moved this from Untriaged to In Review in workers-sdk Oct 18, 2026
@petebacondarwin
petebacondarwin enabled auto-merge (squash) October 18, 2026 15:25

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from In Review to Approved in workers-sdk Oct 18, 2026
@petebacondarwin
petebacondarwin merged commit c4b18e1 into main Oct 18, 2026
91 checks passed
@petebacondarwin
petebacondarwin deleted the dependabot/npm_and_yarn/packages/create-cloudflare/src/frameworks/create-astro-5.3.0 branch October 18, 2026 15:26
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-pr-description-validation Skip validation of the required PR description format dependencies Used by dependabot to mark PRs as updates to dependencies. package:c3 Relating to C3 (create-cloudflare) package

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants