Repository navigation
[C3] Bump create-astro from 5.2.6 to 5.3.0 in /packages/create-cloudflare/src/frameworks - #16342
Conversation
Bumps [create-astro](https://github.com/withastro/astro/tree/HEAD/packages/create-astro) from 5.2.6 to 5.3.0. - [Release notes](https://github.com/withastro/astro/releases) - [Changelog](https://github.com/withastro/astro/blob/main/packages/create-astro/CHANGELOG.md) - [Commits](https://github.com/withastro/astro/commits/create-astro@5.3.0/packages/create-astro) --- updated-dependencies: - dependency-name: create-astro dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
🦋 Changeset detectedLatest commit: ba88f26 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
💬 Approved with comments — This is a clean dependency bump. Both Astro templates now declare the Node.js >=22.22.0 requirement, and tests cover it. The only comment is a small wording fix in the changeset. Findings: 1 suggestion The decision is advisory: this comment never approves, blocks or requests changes on the pull request. 🔧 Fix with your agentPaste the following into your coding agent to investigate and fix these issues. 📝 Documentation: 💬 1 suggestionThe changeset wording overstates which Node.js versions get Astro's upgrade message Recommendation: 💬 Optional Nits
View full review
Consider saying the message applies to Node.js versions C3 supports, or mention both minimums. This is changelog wording only and does not affect runtime behaviour. ✅ All other checks passed📋 Code Quality: ✅ LGTMThe bump to
This review did not cover the lockfile changes, and the tests were not run. Reviewed commit: |
The following dependency versions have been updated: | Dependency | From | To | | ------------ | ----- | ----- | | create-astro | 5.2.6 | 5.3.0 |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
left a comment
There was a problem hiding this comment.
The create-astro 5.3.0 package raises its Node.js minimum from >=22.12.0 to >=22.22.0, while C3 accepts Node >=22.0.0 and neither Astro template sets frameworkCliNodeVersion. This newly breaks Astro scaffolding on Node 22.12–22.21. Please add a compatible generator selection or a version gate/fallback for both Astro templates, with boundary coverage, before merging.
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Bumps create-astro from 5.2.6 to 5.3.0.
Release notes
Sourced from create-astro's releases.
Changelog
Sourced from create-astro's changelog.
Commits
c2c43a9[ci] release (#18354)2715958feat: increase minimum Node.js version to 22.22.0 (#18277)acc0460chore(create): no longer link a CLAUDE.md in create-astro (#18218)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)