Skip to content

[vite-plugin] Remove no-effect v1 backports - #16365

Merged
petebacondarwin merged 1 commit into
vite-plugin-v1from
codex/vite-v1-remove-no-effect-backports
Oct 19, 2026
Merged

petebacondarwin merged 1 commit into
vite-plugin-v1from
codex/vite-v1-remove-no-effect-backports

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

The scheduled backport prompt required a separate PR for every compatible original, even when an earlier dependency upgrade supplied the entire fix. This added upstream dependency tests and Vite plugin release notes without changing the plugin.

Revert these three merged backports against the current vite-plugin-v1 branch:

Backport Removed coverage Reason
#16316 (original #13742) Installed Wrangler CLI hotkey tests Vite owns its keyboard shortcuts; this only tests wrangler dev.
#16315 (original #16284) Installed Wrangler CLI rollback tests and their shared helper Wrangler rollback output has no effect on the Vite plugin.
#16290 (original #16257) Direct Miniflare Runtime tests with mocked process spawning The runtime upgrade is already supplied by #16289; this PR only duplicates upstream dependency coverage.

Remove their three pending plugin changesets as well. The combined revert deletes seven files (404 lines). All implementation files, dependency pins, and the lockfile remain unchanged, including the useful remote-bindings fixes and dependency upgrades in #16289. The experimental configuration removal in #16363 is preserved.

The scheduled prompt has also been updated to require a concrete v1 effect, record originals already covered by an earlier backport, and exclude source/tests/helpers/fixtures belonging to absent public sibling packages. Future scans must respect intentional reversions instead of recreating these PRs. This prompt change is saved in the scheduled task rather than this repository.

Closed the redundant unmerged follow-ups #16354 and #16355: both added only tests and release notes for runtime versions already supplied by #16333. The remaining useful open backports are #16333 and #16334.

Validation with Node.js 22.22.1 and pnpm 10.33.0:

  • Frozen dependency installation and pnpm build passed.
  • pnpm test:ci passed all 8 retained tasks, including 206 plugin tests.
  • pnpm check passed all 58 tasks in a clean temporary checkout. The initial format scan in the main checkout encountered 19 existing generated artifacts from absent packages; their contents were left untouched.
  • Confirmed the diff contains exactly the seven intended deletions, no dangling references to the removed test helper, and no dependency or implementation changes. Whitespace checks pass.

No new changeset is needed for this test-only cleanup and removal of irrelevant pending release notes.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this removes unrelated dependency tests and release notes without changing Vite plugin behavior or public APIs.

Note

This is a contribution from an AI agent: Codex, preparing maintainer-requested cleanup.


Devin Review

Revert #16316, #16315, and #16290, which added only upstream Wrangler/Miniflare tests and plugin release notes. Keep the actual fixes already supplied by the dependency upgrades in #16289.
@petebacondarwin petebacondarwin added ci:no-changeset-required Skip pull request checks for a valid changeset package:vite-plugin Relating to the `@cloudflare/vite-plugin` package labels Oct 19, 2026
@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a8b8d48

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 19, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16365

commit: a8b8d48

@ask-bonk

ask-bonk Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread .changeset/vite-v1-occupied-port-diagnostics.md
@workers-devprod
workers-devprod requested review from a team and edmundhung and removed request for a team October 19, 2026 15:31
@workers-devprod

workers-devprod commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

@clanky-the-clanker

Copy link
Copy Markdown

✅ Approved — This pull request only deletes tests that exercise upstream dependency behaviour, the helper those tests share, and three pending changesets. Nothing else references the removed files, and no implementation code or dependency changes.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

🚀 Release: ✅ LGTM

Risk: Low. The pull request removes three pending plugin changesets that describe fixes the v1 plugin already gets from earlier dependency upgrades, so the next release notes will no longer list them. The remaining changesets are unaffected.


🔒 Security: ✅ LGTM

No security concerns. The change only removes test files and changesets.


📖 AGENTS.md: ✅ LGTM

The pull request follows the branch conventions: it targets vite-plugin-v1, uses the [vite-plugin] title prefix and adds no changeset for a change that users will not see.


📋 Code Quality: ✅ LGTM

This pull request only deletes files: test specs, the one test helper they share, and three changesets. Nothing in the repository still references the removed files. There are no imports of published-wrangler or startPublishedWrangler, and no mentions of the deleted spec names. The plugin still uses @cloudflare/workers-utils in other tests and in containers.ts, so removing these tests leaves no orphaned dependency. The miniflare and wrangler pins in packages/vite-plugin-cloudflare/package.json are unchanged.

The deleted tests only exercised upstream behaviour: wrangler dev hotkeys, wrangler rollback output, and Miniflare Runtime startup diagnostics. That fits the stated reason for removing them, which is that they have no effect on the plugin. This review did not re-run the validation claims in the description, such as the CI test counts.


⚡ Performance: ✅ LGTM

No performance impact. Removing these tests slightly shortens the test run.


📝 Documentation: ✅ LGTM

No documentation impact.


Reviewed commit: a8b8d48c

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@petebacondarwin
petebacondarwin merged commit ef120cf into vite-plugin-v1 Oct 19, 2026
28 of 32 checks passed
@petebacondarwin
petebacondarwin deleted the codex/vite-v1-remove-no-effect-backports branch October 19, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset package:vite-plugin Relating to the `@cloudflare/vite-plugin` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants