Repository navigation
[vite-plugin] Remove no-effect v1 backports - #16365
Conversation
|
commit: |
|
LGTM |
|
Codeowners approval required for this PR:
|
|
✅ Approved — This pull request only deletes tests that exercise upstream dependency behaviour, the helper those tests share, and three pending changesets. Nothing else references the removed files, and no implementation code or dependency changes. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed🚀 Release: ✅ LGTMRisk: Low. The pull request removes three pending plugin changesets that describe fixes the v1 plugin already gets from earlier dependency upgrades, so the next release notes will no longer list them. The remaining changesets are unaffected. 🔒 Security: ✅ LGTMNo security concerns. The change only removes test files and changesets. 📖 AGENTS.md: ✅ LGTMThe pull request follows the branch conventions: it targets 📋 Code Quality: ✅ LGTMThis pull request only deletes files: test specs, the one test helper they share, and three changesets. Nothing in the repository still references the removed files. There are no imports of The deleted tests only exercised upstream behaviour: ⚡ Performance: ✅ LGTMNo performance impact. Removing these tests slightly shortens the test run. 📝 Documentation: ✅ LGTMNo documentation impact. Reviewed commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
The scheduled backport prompt required a separate PR for every compatible original, even when an earlier dependency upgrade supplied the entire fix. This added upstream dependency tests and Vite plugin release notes without changing the plugin.
Revert these three merged backports against the current
vite-plugin-v1branch:wrangler dev.Runtimetests with mocked process spawningRemove their three pending plugin changesets as well. The combined revert deletes seven files (404 lines). All implementation files, dependency pins, and the lockfile remain unchanged, including the useful remote-bindings fixes and dependency upgrades in #16289. The experimental configuration removal in #16363 is preserved.
The scheduled prompt has also been updated to require a concrete v1 effect, record originals already covered by an earlier backport, and exclude source/tests/helpers/fixtures belonging to absent public sibling packages. Future scans must respect intentional reversions instead of recreating these PRs. This prompt change is saved in the scheduled task rather than this repository.
Closed the redundant unmerged follow-ups #16354 and #16355: both added only tests and release notes for runtime versions already supplied by #16333. The remaining useful open backports are #16333 and #16334.
Validation with Node.js 22.22.1 and pnpm 10.33.0:
pnpm buildpassed.pnpm test:cipassed all 8 retained tasks, including 206 plugin tests.pnpm checkpassed all 58 tasks in a clean temporary checkout. The initial format scan in the main checkout encountered 19 existing generated artifacts from absent packages; their contents were left untouched.No new changeset is needed for this test-only cleanup and removal of irrelevant pending release notes.
Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested cleanup.