Skip to content

[vite-plugin] Backport Workflow storage cleanup to v1 - #16379

Draft
petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16259from
codex/vite-v1-backport-16183
Draft

petebacondarwin wants to merge 1 commit into
codex/vite-v1-backport-16259from
codex/vite-v1-backport-16183

Conversation

@petebacondarwin

Copy link
Copy Markdown
Contributor

Backport the remaining useful runtime behavior from #16183 through the next published Miniflare release, without restoring Miniflare, Wrangler, workflows-shared source or their upstream tests.

Vite plugin v1 forwards its local Explorer endpoints to Miniflare and provides Workflow bindings in dev/preview. The new runtime moves Workflow persistence operations onto the native disk service and queues deletion with instance recreation. This includes local Explorer deletion and Workflow instance reuse, in addition to the original Node RPC deadlock fix. The v1 plugin has no createTestHarness API, so this PR does not copy its Wrangler tests or claim a new plugin API.

Draft: npm publication is blocked. Open main release PR #16377 records intended Miniflare 5.20261019.2-beta and Wrangler 4.151.4; the Miniflare version returns npm E404. Set the intended matching runtime pins in the plugin, retained private remote-bindings, and account-id E2E fixture, plus the plugin's Wrangler peer minimum. Preserve the lockfile's actual published 5.20261019.1-beta / 4.151.3 metadata instead of inventing tarballs or integrity hashes. Frozen install is therefore expected to fail until publication and regeneration; this draft is not ready to merge.

Stacked on #16378, above #16373/#16334/#16333. Earlier #16333 already supplies Miniflare 5.20261019.1-beta and the #15708 Workflow cleanup fix; this PR only carries the next storage fix and its plugin patch changeset. All private workspace:* references and intentional v1 removals remain intact.

Validation: inspected the original runtime diff, v1 manifests, and effective open stack; whitespace and PR description checks pass. The published parent stack passes build, retained tests, all 58 checks, dev/build Workflow playgrounds, and offline frozen install. These results validate the parent versions, not the unpublished versions proposed here. After npm publication, regenerate the lockfile with pnpm install and run build, types/checks, retained suites, and the existing Workflow dev/preview playgrounds before marking ready. Add a plugin-level regression only if an uncovered v1 behavior requires it; keep upstream tests upstream.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: the fix belongs to public dependency source, covered upstream; existing plugin Workflow dev/preview playgrounds must be rerun after publication. Validation of proposed versions is currently blocked.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this consumes a compatible runtime fix for existing local Workflow behavior; the plugin changeset describes it.

Note

This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@edmundhung (recorded author of #16183) and @dario-piotrowicz (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it when it is ready and looks good?

This draft consumes the runtime fix through the intended Miniflare 5.20261019.2-beta / Wrangler 4.151.4 pins from pending release #16377. It preserves real lockfile metadata while npm publication is pending; lockfile regeneration and build/type/Workflow playground validation must follow. V1 uses the runtime's Workflow bindings and local Explorer; removed public source, test-harness APIs and upstream tests are not copied. Earlier #16333 already supplies the #15708 cleanup fix, and this stacks on #16378.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant