Repository navigation
[vite-plugin] Backport Workflow storage cleanup to v1 - #16379
Draft
petebacondarwin wants to merge 1 commit into
Draft
petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
Contributor
Author
|
@edmundhung (recorded author of #16183) and @dario-piotrowicz (verified human ant-core approver), could you please check this Vite plugin v1 backport and approve it when it is ready and looks good? This draft consumes the runtime fix through the intended Miniflare 5.20261019.2-beta / Wrangler 4.151.4 pins from pending release #16377. It preserves real lockfile metadata while npm publication is pending; lockfile regeneration and build/type/Workflow playground validation must follow. V1 uses the runtime's Workflow bindings and local Explorer; removed public source, test-harness APIs and upstream tests are not copied. Earlier #16333 already supplies the #15708 cleanup fix, and this stacks on #16378. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the remaining useful runtime behavior from #16183 through the next published Miniflare release, without restoring Miniflare, Wrangler, workflows-shared source or their upstream tests.
Vite plugin v1 forwards its local Explorer endpoints to Miniflare and provides Workflow bindings in dev/preview. The new runtime moves Workflow persistence operations onto the native disk service and queues deletion with instance recreation. This includes local Explorer deletion and Workflow instance reuse, in addition to the original Node RPC deadlock fix. The v1 plugin has no createTestHarness API, so this PR does not copy its Wrangler tests or claim a new plugin API.
Draft: npm publication is blocked. Open main release PR #16377 records intended Miniflare
5.20261019.2-betaand Wrangler4.151.4; the Miniflare version returns npm E404. Set the intended matching runtime pins in the plugin, retained private remote-bindings, and account-id E2E fixture, plus the plugin's Wrangler peer minimum. Preserve the lockfile's actual published5.20261019.1-beta/4.151.3metadata instead of inventing tarballs or integrity hashes. Frozen install is therefore expected to fail until publication and regeneration; this draft is not ready to merge.Stacked on #16378, above #16373/#16334/#16333. Earlier #16333 already supplies Miniflare 5.20261019.1-beta and the #15708 Workflow cleanup fix; this PR only carries the next storage fix and its plugin patch changeset. All private workspace:* references and intentional v1 removals remain intact.
Validation: inspected the original runtime diff, v1 manifests, and effective open stack; whitespace and PR description checks pass. The published parent stack passes build, retained tests, all 58 checks, dev/build Workflow playgrounds, and offline frozen install. These results validate the parent versions, not the unpublished versions proposed here. After npm publication, regenerate the lockfile with pnpm install and run build, types/checks, retained suites, and the existing Workflow dev/preview playgrounds before marking ready. Add a plugin-level regression only if an uncovered v1 behavior requires it; keep upstream tests upstream.
Note
This is a contribution from an AI agent: Codex, preparing maintainer-requested v1 backports.