Repository navigation
[vite-plugin] Preserve v1 remote-binding error properties - #16542
Conversation
🦋 Changeset detectedLatest commit: 2a73b54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@dinasaur404 (original author) @edmundhung (human ant-core approver): please check this v1 backport of #16499 and approve it if it looks good. Only the retained remote proxy Worker's enhanced_error_serialization flag and a plugin patch changeset remain here; #16539 already supplies the published Miniflare serialization changes. No dependency upgrade is repeated and no public dependency tests/source are copied. Build/checks and existing retained test suites pass; live remote-account error validation is unavailable without credentials. |
|
Codeowners approval required for this PR:
|
|
✅ Approved — A small change that is easy to follow: it enables one compatibility flag and adds a correct changeset. No issues found. The decision is advisory: this comment never approves, blocks or requests changes on the pull request. ✅ All checks passed📋 Code Quality: ✅ LGTMThe added 📝 Documentation: ✅ LGTMThe changeset describes the user-facing behaviour accurately and gives the Miniflare version it depends on. Reviewed commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
commit: |
Consolidate the existing final backport diff before rebasing onto the current v1 stack. #16542
5b4d991 to
2a73b54
Compare
Backports the independently useful retained remote-binding portion of #16499 to Vite plugin v1, stacked on #16539, the canonical-registry runtime backport.
Enable
enhanced_error_serializationon the remote proxy Worker uploaded by the retained@cloudflare/remote-bindingspackage. Without this flag, remote binding errors lose machine-readable properties before reaching v1's user Worker. Miniflare5.20261023.1-beta, supplied by #16539, already supplies the public proxy/Node error serialization changes; no dependency bump is repeated here.Only the retained source flag and a plugin patch changeset remain. Do not restore Miniflare source or copy its error-serialization tests into v1. The existing retained remote-binding tests and plugin test suites cover session startup and integration; live remote-account error validation requires Cloudflare credentials unavailable in this environment.
Validation: Node 22.22.1 / pnpm 10.33.0;
pnpm build,pnpm check,pnpm test:ci, andpnpm test:fixturesagainst the published parent dependencies.Note
This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.