Skip to content

[vite-plugin] Preserve v1 remote-binding error properties - #16542

Merged
petebacondarwin merged 1 commit into
codex/vite-v1-backport-16494from
codex/vite-v1-backport-16499
Oct 28, 2026
Merged

petebacondarwin merged 1 commit into
codex/vite-v1-backport-16494from
codex/vite-v1-backport-16499

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Backports the independently useful retained remote-binding portion of #16499 to Vite plugin v1, stacked on #16539, the canonical-registry runtime backport.

Enable enhanced_error_serialization on the remote proxy Worker uploaded by the retained @cloudflare/remote-bindings package. Without this flag, remote binding errors lose machine-readable properties before reaching v1's user Worker. Miniflare 5.20261023.1-beta, supplied by #16539, already supplies the public proxy/Node error serialization changes; no dependency bump is repeated here.

Only the retained source flag and a plugin patch changeset remain. Do not restore Miniflare source or copy its error-serialization tests into v1. The existing retained remote-binding tests and plugin test suites cover session startup and integration; live remote-account error validation requires Cloudflare credentials unavailable in this environment.

Validation: Node 22.22.1 / pnpm 10.33.0; pnpm build, pnpm check, pnpm test:ci, and pnpm test:fixtures against the published parent dependencies.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: this enables the upstream-tested serialization flag in retained session configuration; existing session/plugin suites pass and no upstream dependency test is duplicated.
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this restores error properties through the existing remote-binding API and is described in the plugin changeset.

Note

This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.


Devin Review

@petebacondarwin petebacondarwin added the ci:no-tests Skip pull request checks for tests label Oct 28, 2026
@changeset-bot

changeset-bot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2a73b54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin

Copy link
Copy Markdown
Contributor Author

@dinasaur404 (original author) @edmundhung (human ant-core approver): please check this v1 backport of #16499 and approve it if it looks good. Only the retained remote proxy Worker's enhanced_error_serialization flag and a plugin patch changeset remain here; #16539 already supplies the published Miniflare serialization changes. No dependency upgrade is repeated and no public dependency tests/source are copied. Build/checks and existing retained test suites pass; live remote-account error validation is unavailable without credentials.

@workers-devprod
workers-devprod requested review from a team and NuroDev and removed request for a team October 28, 2026 11:11
@workers-devprod

workers-devprod commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler

devin-ai-integration[bot]

This comment was marked as resolved.

@clanky-the-clanker

clanky-the-clanker Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Approved — A small change that is easy to follow: it enables one compatibility flag and adds a correct changeset. No issues found.

The decision is advisory: this comment never approves, blocks or requests changes on the pull request.


✅ All checks passed

📋 Code Quality: ✅ LGTM

The added enhanced_error_serialization flag in start-remote-proxy-session.ts is small and has a comment explaining it. No issues found.


📝 Documentation: ✅ LGTM

The changeset describes the user-facing behaviour accurately and gives the Miniflare version it depends on.


Reviewed commit: 2a73b541 — same changes as 5b4d991a, so this is that commit's review (no new review was run; line numbers are as of 5b4d991a)

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/vite-plugin@16542

commit: 2a73b54

Consolidate the existing final backport diff before rebasing onto the current v1 stack.

#16542
@petebacondarwin
petebacondarwin force-pushed the codex/vite-v1-backport-16499 branch from 5b4d991 to 2a73b54 Compare October 28, 2026 11:42
@petebacondarwin
petebacondarwin merged commit ef573d4 into vite-plugin-v1 Oct 28, 2026
28 of 45 checks passed
@petebacondarwin
petebacondarwin deleted the codex/vite-v1-backport-16499 branch October 28, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:no-tests Skip pull request checks for tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants